Menu

#646 Scripting window layout leaves "RUN" button out

3.1
closed-fixed
None
5
2014-05-19
2013-12-27
No

On Mac, the default display of the Scripting window leaves 2 button out without hints of their presence: [12] and [RUN].

See attached screenshot.

I suggest a vertical layout with the [RUN] button at the top.

1 Attachments

Related

Bugs: #646

Discussion

  • Didier Briel

    Didier Briel - 2013-12-27

    On Mac, the default display of the Scripting window leaves 2 button out without hints of their presence: [12] and [RUN].

    Is that the case on all Macs?

    I suggest a vertical layout with the [RUN] button at the top.

    It would take too much space, IMHO. It would be simplest to dimension the window so that all buttons fit automatically (unless the screen is too small).

    Didier

     
    • Jean-Christophe Helary

      I tried on the laptop and on the imac and both show this behaviour, and not
      because of lack of screen space.

      The problem with resizing the window is that there is no indication that
      the window needs resizing to display the full contents. So a first time
      user is left without a way to run the script since the RUN button won't
      show.

      On Sat, Dec 28, 2013 at 1:40 AM, Didier Briel didierbr@users.sf.net wrote:

      On Mac, the default display of the Scripting window leaves 2 button out
      without hints of their presence: [12] and [RUN].

      Is that the case on all Macs?

      I suggest a vertical layout with the [RUN] button at the top.

      It would take too much space, IMHO. It would be simplest to dimension the
      window so that all buttons fit automatically (unless the screen is too
      small).

      Didier

      Status: open
      Created: Fri Dec 27, 2013 02:31 PM UTC by Jean-Christophe Helary
      Last Updated: Fri Dec 27, 2013 02:31 PM UTC
      Owner: nobody

      On Mac, the default display of the Scripting window leaves 2 button out
      without hints of their presence: [12] and [RUN].

      See attached screenshot.

      I suggest a vertical layout with the [RUN] button at the top.

      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/omegat/bugs/646/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #646

  • Didier Briel

    Didier Briel - 2013-12-28

    The problem with resizing the window is that there is no indication that
    the window needs resizing to display the full contents. So a first time
    user is left without a way to run the script since the RUN button won't
    show.

    What part of "automatically" did you miss? :)

    Didier

     
    • Jean-Christophe Helary

      The part where it was not visible on my screen… ;)

      But I still think a vertical layout would take less space

      On Dec 28, 2013, at 19:02, Didier Briel didierbr@users.sf.net wrote:

      The problem with resizing the window is that there is no indication that
      the window needs resizing to display the full contents. So a first time
      user is left without a way to run the script since the RUN button won't
      show.

      What part of "automatically" did you miss? :)

      Didier

      [bugs:#646] Scripting window layout leaves "RUN" button out

      Status: open
      Created: Fri Dec 27, 2013 02:31 PM UTC by Jean-Christophe Helary
      Last Updated: Fri Dec 27, 2013 04:40 PM UTC
      Owner: nobody

      On Mac, the default display of the Scripting window leaves 2 button out without hints of their presence: [12] and [RUN].

      See attached screenshot.

      I suggest a vertical layout with the [RUN] button at the top.

       
  • Didier Briel

    Didier Briel - 2013-12-30

    But I still think a vertical layout would take less space

    Can you send me a crude mock-up?

    Didier

     
  • Jean-Christophe Helary

    Here is the crude mock-up.

     
  • Didier Briel

    Didier Briel - 2013-12-30

    Thanks, I understand now what you mean by "vertically".

    It does gain space (in some cases), but you loose in usability, IMHO.

    I still think automatic redimensionning would be a better solution.

    Didier

     
  • Yu Tang

    Yu Tang - 2014-01-01

    Free quick buttons set text like this.

    m_quickScriptButtons[index].setText(" " + scriptKey + " ");
    

    These two spaces makes button wider.
    So probably the most easiest solution is getting rid of both side spaces.
    Just a thought.

     
    • Didier Briel

      Didier Briel - 2014-01-02

      At the location you mention (// Remove a script from the button bar), I think the spaces are only there to clean the < and > of a previously allocated location.

      Didier

       
      • Yu Tang

        Yu Tang - 2014-01-03

        Thank you for pointing it out.
        I tried to trim button text. See attached screenshot.
        Button widths are shrank, but it seems not enough for the case.

         
  • Yu Tang

    Yu Tang - 2014-01-26

    I changed the buttons layout from FlowLayout to BoxLayout.
    It seems OK for me.
    What do you think?

     
  • Didier Briel

    Didier Briel - 2014-01-27

    That doesn't look bad. I think you can commit to /trunk. That way, Jean-Christophe will be able to test on his Mac.

    Didier

     
    • Jean-Christophe Helary

      Honestly, I prefer the vertical layout, eventually on the left of the window (and not on the right as in my mock-up).
      But anything that shows the whole thing is fine.

       
  • Jean-Christophe Helary

    Button 12 is now visible, but not button RUN.

     
  • Didier Briel

    Didier Briel - 2014-01-27

    Going to BoxLayout is not a solution then. Sorry Yu Tang, I revert.

    Didier

     
    • Yu Tang

      Yu Tang - 2014-01-27

      No problem at all.
      Well, now I'm considering buying a Mac Air or Pro.

       
  • Didier Briel

    Didier Briel - 2014-03-10

    Fixed in SVN (/trunk).

    It was fixed by changing slightly the layout and by putting the Run button on the left.

    Didier

     
  • Didier Briel

    Didier Briel - 2014-03-10
    • status: open --> open-fixed
    • assigned_to: Jean-Christophe Helary
     
  • Didier Briel

    Didier Briel - 2014-05-19
    • status: open-fixed --> closed-fixed
    • Group: 3.0 --> 3.1
     
  • Didier Briel

    Didier Briel - 2014-05-19

    Closing.

    Fixed in the released version 3.1.0 of OmegaT.

    Didier

     

Log in to post a comment.