Menu

#85 Use <label> for $reapply_filters in html_top_table.php

closed-fixed
None
5
2006-10-11
2006-10-10
Tim Gerundt
No

This patch adds the <label> tag to *reapply_filters* in
the file "html/html_top_table.php".
It also put the checkbnox *before* the text, like the
other preferences.

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2006-10-10

    original and altered file

     
  • Anonymous

    Anonymous - 2006-10-10
    • assigned_to: nobody --> goddess_skuld
     
  • Anonymous

    Anonymous - 2006-10-10

    Logged In: YES
    user_id=529507

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2006-10-10
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2006-10-11
    • status: closed-fixed --> open
     
  • Tim Gerundt

    Tim Gerundt - 2006-10-11

    Logged In: YES
    user_id=652377

    Sorry, there was a small bug in my last patch! :-(
    I removed the <div>, since I thought it is unnecessary. But
    in XHTML 1.1 must be form elements (<input>, <select>, ...)
    inside a block element (<div>, <table>, <p>, ...). I didn't
    know it.

    So, the new patch adds the <div> again! ;)

    Greetings,
    Tim

    Btw: I search for this problem and found it in
    "html/send.php" too.

    You must change line 18 from
    <input type="hidden" name="forward_msgnum" value="<?php echo
    $forward_msgnum ?>" />
    to
    <div><input type="hidden" name="forward_msgnum" value="<?php
    echo $forward_msgnum ?>" /></div>

     
  • Tim Gerundt

    Tim Gerundt - 2006-10-11

    original and altered file (Version 2)

     
  • Anonymous

    Anonymous - 2006-10-11
    • status: open --> closed-fixed
     
  • Anonymous

    Anonymous - 2006-10-11

    Logged In: YES
    user_id=529507

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     

Log in to post a comment.

MongoDB Logo MongoDB