#508 php 7.2 breaks session management

[Oliver Heil]

php 7.2 breaks session management.
See Help thread: https://sourceforge.net/p/nocc/discussion/38301/thread/528cca66/

Hi, I upgraded from PHP 7.1.1.2 to 7.2.0, when it came out in november, and nocc stopped working. I am getting these in my php.log (abbreviated paths):
PHP Warning: session_name(): Cannot change session name when session is active in classes\nocc_session.php on line 315
PHP Warning: session_name(): Cannot change session name when session is active in classes\nocc_session.php on line 490
(Before 7.2.0 I got some "deprecated" warnings, but they were not a problem, and I will probably see them again, once I manage to log in, unless nocc.1.9.7 has fixed them.)
I have tried to revert back to 7.1.1.2 and all worked again (with 1.9.7), and it broke again when again shifting to 7.2.0 so it HAS to be a 7.2.0 compatiblity issue - most likely nocc always did it "wrong", and now it is just not allowed anymore?
- or am I missing something in my configuration?

The result is that the client reports "Could not connect to server".

Solution:

for NOCC versions <= 1.9.7 and php 7.2 (and above) the files
action.php
classes/nocc_session.php
should be replaced by the following files:
https://sourceforge.net/p/nocc/code/2737/tree/trunk/webmail/action.php
https://sourceforge.net/p/nocc/code/2737/tree/trunk/webmail/classes/nocc_session.php

Direct download links:
https://sourceforge.net/p/nocc/code/2737/tree/trunk/webmail/action.php?format=raw
https://sourceforge.net/p/nocc/code/2737/tree/trunk/webmail/classes/nocc_session.php?format=raw

[Felipe]