Menu ▾ ▴

#325 More mixed EOL in some files

closed-fixed
Other (69)
5
2006-09-27
2006-09-26
Tim Gerundt
No

Mhh, after your last CVS commits, I have some more
files with mixed EOL:

* functions.php
* html/html_mail_top.php
* themes/blue/style.css
* themes/newlook/style.css
* themes/standard/style.css

Greetings,
Tim Gerundt

Discussion

  • Anonymous

    Anonymous - 2006-09-27

    Logged In: YES
    user_id=529507

    It's seems it's the file that I have added from the one you
    have submitted with your patches, not from the diff files.

    You text editor seems to add new lines with Windows line
    feed even if the file contains Unix line feed.

     
  • Anonymous

    Anonymous - 2006-09-27
    • assigned_to: nobody --> goddess_skuld
     
  • Anonymous

    Anonymous - 2006-09-27

    Logged In: YES
    user_id=529507

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the bug report.

     
  • Anonymous

    Anonymous - 2006-09-27
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2006-09-27

    Logged In: YES
    user_id=652377

    > You text editor seems to add new lines with Windows line
    > feed even if the file contains Unix line feed.

    Sorry for that! But it seems not to be my editor. All the
    files looks good! Maybe it happens, if I zip the files, or
    you unzip them?

    If I ceckout the files from CVS, they have the Windows line
    feed (CrLf). Is this correct?

     
  • Anonymous

    Anonymous - 2006-09-27

    Logged In: YES
    user_id=529507

    > Sorry for that! But it seems not to be my editor. All the
    > files looks good! Maybe it happens, if I zip the files, or
    > you unzip them?

    I unzip them under MacOS X or FreeBSD, which use Unix line
    feed. I don't know if these versions changes line feed, and
    it's weird if it changes only some line feed and not all of
    them.

    > If I ceckout the files from CVS, they have the Windows
    > line feed (CrLf). Is this correct?

    WinCVS may change line feed. If I remember well, there's an
    option to change line feeds or not. When I commit files, I
    try not to forget so set Unix line feeds. But neither Nocc
    nor PHP cares about line feed, there's nothing wrong to use
    Windows, Unix or mixed line feeds. But I admit the last case
    is dirty :)

     

Log in to post a comment.