#867 XSPICE disable & RSHUNT

[Danial Chitnis]

Hello, this may be a bit old, becuase I had a bug in my test script I didn't catch this bug earlier:

When building with --disable-xspice, I get the following error:

../../../../src/spicelib/analysis/cktsopt.c: In function 'CKTsetOpt':
../../../../src/spicelib/analysis/cktsopt.c:254:10: error: 'OPT_ENH_RSHUNT' undeclared (first use in this function); did you mean 'OPT_CSHUNT'?
  254 |     case OPT_ENH_RSHUNT:
      |          ^~~~~~~~~~~~~~
      |          OPT_CSHUNT
../../../../src/spicelib/analysis/cktsopt.c:254:10: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [Makefile:643: cktsopt.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/tmp/ngspice-native/release/src/spicelib/analysis'
make[2]: *** [Makefile:402: all-recursive] Error 1
make[2]: Leaving directory '/tmp/ngspice-native/release/src/spicelib'

The bug seems to be in:

#else
    case OPT_ENH_RSHUNT:
        fprintf(stderr, "WARNING - Option Rshunt available only with XSPICE enabled.\n");
        break;
#endif

and

#ifdef XSPICE
enum {
    OPT_ENH_NOOPALTER = 100,
    OPT_ENH_RAMPTIME,
    OPT_EVT_MAX_EVT_PASSES,
    OPT_EVT_MAX_OP_ALTER,
    OPT_ENH_CONV_LIMIT,
    OPT_ENH_CONV_ABS_STEP,
    OPT_ENH_CONV_STEP,
    OPT_MIF_AUTO_PARTIAL,
    OPT_ENH_RSHUNT,
};
#endif

Also might be another one in OPTtbl.

Thanks,
Danial

[Holger Vogt]

Thanks for the report.

I will remove rshunt from the XSPICE code and move it to standard ngspice.

[Holger Vogt]

I have uploaded a fix to git branch pre-master-48: Option RSHUNT is removed from XSPICE to standard exe, so available without XSPICE compiled in.