Menu

#354 Issues with "gendefs.h, make struct GENinstance truly generic" patch

v1.0 (example)
closed-fixed
None
5
2018-02-17
2018-02-12
No

Patch 7a62d9be3007 ("gendefs.h, make struct GENinstance truly generic") breaks lots of stuff. A simple example:

* test
vcc 1 0 dc 4.5V
.control
op
print v(1)
.endc
.end
v(1) = -4.50000e+00

If I back out the patch, I see

v(1) = 4.500000e+00

I'm building on x86_64 Ubuntu 17.10.

Discussion

  • Robert Larice

    Robert Larice - 2018-02-12

    Your complaint is perfectly correct.

    I forgot this commit is only valid together with another commit,
    which is still in rewrite on a development branch.

    This second commit would have replaced the first few struct elements of device instances
    with a single generic struct.

    I've reset the master branch to remove the offending commit. Please resync your repository
    with a git fetch master and check out anew or reset your local master.

    Thank You very much for your Report,
    Regards,

     
  • Robert Larice

    Robert Larice - 2018-02-17

    The commit is now put into its proper context and reintroduced on the master branch,
    which is currently at here

    You would do me a favor if you try the current master and report if it fails.

    Thank you for the bug report, which I'm closing now,

    Regards,

    Robert

     
  • Robert Larice

    Robert Larice - 2018-02-17
    • status: open --> closed-fixed
    • assigned_to: Robert Larice
     

Log in to post a comment.

MongoDB Logo MongoDB