[Netjuke-devel] Some patches you may want to include
Status: Beta
Brought to you by:
blakewatters
|
From: Michael S. <mso...@gm...> - 2005-01-22 19:37:13
|
On my setup (Fedora 3/alsa/mpg321) I needed to replace
@exec ("kill $pid");
with
@exec ("kill -9 $pid");
in jukebox-edit.php. On the whole I would love a more interactive
jukebox interface that would enable viewing/modifying the current
playlist. I might even work on it, except I have a full time job and
kids...
Here's another pointer though. It was annoying me that band names
beginning "The " sorted under T, so I made this patch to address this
(in alphabet.php):
36,37c36
< . " where (lower(".$col.".name) like
'".strtolower($_REQUEST['val'])."%' "
< . " or lower(".$col.".name) like 'the
".strtolower($_REQUEST['val'])."%' )"
---
> . " where lower(".$col.".name) like '".strtolower($_REQUEST['val'])."%' "
39c38
< . " order by replace(upper(".$col.".name),'THE ','') ";
---
> . " order by upper(".$col.".name) ";
This still doesn't merge the two entries together (which would be the
best), but at least it makes them appear near each opther in the
browse list...
Another request I have is some way to completely disable the
authentication mechanism. I have netjuke installed on a server that
is already locked down in another way and I don't care to track who is
using the site, since it is basically used for playing music on my
home stereo from a central server. So the login is kind of annoying
more than anything else for me. I hacked this by adding:
719,722d718
< if (!isset($NETJUKE_SESSION_VARS["email"])) {
< $NETJUKE_SESSION_VARS["email"] = "my...@my...";
< $NETJUKE_SESSION_VARS["gr_id"] = 1;
< }
to inc-common.php and setting security mode to 0.2, but I think it
might be better to do something like this in the install script.
Thanks for all the hard work you folks are putting in - glad to see
this project seems to be getting revived.
|