#134 Add the patch mp050226-V3-1-CVS20080907-2.patch into nedit 5.7

[ericxuo]

Hi,

In my current Nedit version (5.6), I could add a patch (mp050226-V3-1-CVS20080907-2.patch)
whose function was to add a "Matching Patterns" window in the Preferences->Default Settings -> Show Matching (..)" field (see attached picture).
This patch generates errors when I try to add it in nedit 5.7
Could you modify this patch to make it plugable into nedit 5.7 (and following) ?

Regards.

Xuo.

[ericxuo]

Hi,

I add the picture of the extra menu for "Matching Patterns".

Xuo.

[TK Soh]

I wondering, who's the original author of this patch?

[ericxuo]

Hi,

I "think" it was Bert Wesarg but I'm not sure at all.

Regards.

Xuo.

[TK Soh]

Can you help point to the patch ticket where you downloaded the patch from?
Thanks

[TK Soh]

Can you please help test out the patch I have attached? Quite frankly, I pretty much just updated it blindly, with minimum testing to make sure it doesn't crash. Thanks in advance.

[Bert Wesarg]

I "know" that the patch is from Uwe Lehnert (@ulehnert) ;-)

[TK Soh]

Thanks. I found that patch too. And I updated it to the latest rev on git repo.

BTW, I think this patch should have committed a long time ago, before 5.5 even. Maybe we should do it now? Better late then never.

[TK Soh]

Attached patch updated to latest rev on git.

[Bert Wesarg]

I cannot remember why, but I still have this mod in my NEdit sources:

diff --git a/source/patternMatchData.c b/source/patternMatchData.c
index 4ed8062..78293f5 100644
--- a/source/patternMatchData.c
+++ b/source/patternMatchData.c
@@ -3351,14 +3351,6 @@ static int sortReadPatternElementSet(
sizeOfPat = sizeof(PatternElement ) * result->mpteEnd.pesNumberOfPattern;
result->mpteEnd.pesPattern = (PatternElement )XtMalloc( sizeOfPat );
}
- else
- {
- if (!isMonoPattern)
- {
- errMsg = "min. one end pattern needed";
- return False;
- }
- }

 /*
  * sort pattern elements into start, middle & end arrays.

BTW, the patch only holds the diffstat, not the diff.

[TK Soh]

Sorry I can't quite make out what your mod is trying to tell :-(

I've attached the correct patch here. Still struggling as a newbie to git ;-)

[TK Soh]

Bert,

Have you tried the new patch?

TK

[ericxuo]

Hi,

I've just installed the patch and it works fine.
tar xzf nedit-5.7-src.tar.gz
cd source
ln -s ../makefiles/Makefile.linux
cd ..
patch -p1 < mp050226-V3-1-git-2ea66d9c.patch
make docs
make linux

I agree. If it is possible to include this patch, it will be great.

Thank you very much for your help and my apologies for passing on a baby to Bert who was not his :)

Regards.

Xuo.

[TK Soh]

Glad to know things are working out. Thanks.

BTW, any reason you are using the source tarball rather than just cloning the git repo?

[ericxuo]

Hi,

No reason except I'm not very familiar with git and when I was looking for a "clean" latest version of nedit, the tarfile was highlighted (https://sourceforge.net/projects/nedit/files). I even didn't notice that a git tab was available.

Regards.

Xuo.

[Bert Wesarg]

I have the patch in my NEdit since a very long time already and I may aso have some more patterns already which may be good as the default, I need to check. Though I didn't update my tree for a long time too but I assume rebasing the patch to the current tree, was a no-brainer. But I noticed that there are new NEditMalloc/NEditFree function, which this feature should use too, before merging.

If possible, create a branch with this patch and try to preserver Authorship to 'Uwe Lehnert ulehnert@users.sourceforge.net'.

[TK Soh]

Sounds good. Hope to see some progress soon. Let me know if there's anything I can do to help.