Menu

#350 Backlight default color should be textBgColor

release
closed-fixed
nobody
Program (402)
5
2014-09-26
2004-01-25
No

My nedit.textBgColor setting is set to a light shade of grey,
and I noticed when I enabled the new backlighting option in
5.4, all of the highlighted text now had a white background.
I would expect that for text drawing styles where a
background color has not been provided, nedit should use
the current setting of textBgColor instead of white.

As a workaround, I was able to fix this by manually setting
the background for all of my styles to the same as the
textBgColor, but that will require a lot of work should I ever
change my default background color.

Discussion

  • Tony Balinski

    Tony Balinski - 2004-01-26

    Logged In: YES
    user_id=618141

    If you don't want backlighting, turn it off. Backlighting
    (BL) and syntax highlighting (SH) are supposed to be
    independent. SH takes priority if the pattern's style
    defines a background and both BL and SH are enabled. If the
    problem is the choice of colors, redefine them. (Currently
    you need to do this by hand using a resource.)
    BL is useful for seeing tabs, the ends of lines and control
    characters: all things you don't normally color with SH, but
    might be useful to have appear differently in the window. If
    used with SH, the BL color will be used as the background
    only if the SH style has no defined background also.
    The default BL is intended to allow you to distinguish tabs,
    text, and the empty space beyond the end of lines. This is
    why the normal text BL color is not the same as the default
    background. If you don't like it that way, you should change
    the BL resource, not the SH pattern styles, or, as I said,
    just turn off BL.

     
  • TK Soh

    TK Soh - 2004-01-27

    Logged In: YES
    user_id=411637

    I think the OP has a point here. I've always find the
    default backlighting styles a bit too 'bright', just that I
    didn't use it often enough to be annoyed. I only turn it
    momentarily to tell spaces from tabs.

    Perhaps we should changed the default backlighting styles to
    exclude the normal text. In my experiment, it looks pretty
    close to what I want if I just took out characters 32-126
    from the original list. Afterall, it's those special things
    that we are mostly interested in.

     
  • Tony Balinski

    Tony Balinski - 2004-01-27

    Logged In: YES
    user_id=618141

    We could change the colors, but if we make the normal text
    background the same as the default background, we miss out
    on something I like a lot: seeing trailing spaces! You can't
    win, can you?

    Other than that, I have no objection to redefining the colors.

     
  • TK Soh

    TK Soh - 2004-01-27

    Logged In: YES
    user_id=411637

    I think all we need is to take out the normal text, and keep
    the white spaces. So that make the range 33-126 we need to
    remove from the original list?

     
  • Tony Balinski

    Tony Balinski - 2004-01-27

    Logged In: YES
    user_id=618141

    I think that would do, as long as we don't end up having
    complaints about overbright spaces ;-)

     
  • TK Soh

    TK Soh - 2004-01-27

    Logged In: YES
    user_id=411637

    I can help put in the change if you are ready.

     
  • Tony Balinski

    Tony Balinski - 2004-01-27

    Logged In: YES
    user_id=618141

    That's great. Unless Colin has any objections (speak now or
    forever hold your peace!), please go ahead and make the change.

     
  • Colin Simmonds

    Colin Simmonds - 2004-01-27

    Logged In: YES
    user_id=150958

    The change sounds reasonable to me.

     
  • TK Soh

    TK Soh - 2004-01-28

    Logged In: YES
    user_id=411637

    It is now in CVS.

    Colin, remember you can always change the list through the
    resource, especially if you choose to stay with 5.4.

     
  • Eddy De Greef

    Eddy De Greef - 2004-02-03
    • milestone: --> release
    • status: open --> closed-fixed
     

Log in to post a comment.