#58 Deprecated code in language.inc

[Theophilix]

Hello,

I am working with a programmer who made Joomla MRBS Bridge work again for me. He told me there was deprecated / old not working php code that would prevent MRBS from working with Joomla 3.6.2 and PHP 7.
Now my question is: Is this true? How can we keep language.inc for the future, so also Joomla users can use MRBS? See the revised, clean language.inc attached.
Thanks,
Theophilix

[Campbell Morrison]

I don't think MRBS uses any deprecated features. If you run MRBS on PHP 7 with an error reporting level of -1, then none are reported. Which language features do you think are causing a problem?

I think the issue is that the Joomla MRBS Bridge is a separate project and not part of MRBS and I suspect it is still using an old version of language.inc.

[Theophilix]

Thank you very much for your comment on my problem. You guys from MRBS do an awesome work! Keep going!

[Ocean]

The MRBS Brigde does not override language.inc it is using the core files of MRBS. The only override is a small part of the translation file and the config.inc.php

[Anonymous]

Why its not working in latest joomla?

If your languae files is correctly ?

[Ocean]

please check https://github.com/Syndes/Joomla-MRBS-Bridge/issues/3#issuecomment-246184137

[John Beranek]

Cross-posted from the Github issue:

Well, it's not that MRBS is using PHP functions deprecated in PHP 7, it's that it has implemented some functions that Joomla has also implemented, like utf8_strlen:

http://fossies.org/dox/Joomla_3.6.2-Stable-Full_Package/vendor_2joomla_2string_2src_2phputf8_2mbstring_2core_8php.html

[Anonymous]

Cross-posted from the Github issue:

Well, it's not that MRBS is using PHP functions deprecated in PHP 7, it's that it has implemented some functions that Joomla has also implemented, like utf8_strlen:

http://fossies.org/dox/Joomla_3.6.2-Stable-Full_Package/vendor_2joomla_2string_2src_2phputf8_2mbstring_2core_8php.html

Why you not follow all function with any particular class...

Problem is utf8_substr ,utf8_strlen,utf8_strtolower this are used in latest joomla..
and its also function in language.inc..

Thats why gives redeclared error.so please update your MRBS system.and language.inc files code else none of user is used in latest joomla3.6.2

[Campbell Morrison]

Well, you could ask the same question of Joomla. But anyway, I will update MRBS so that it is namespaced.

[Anonymous]

Thanks for the your advice but i know your used joomla config file in your system.

Not joomla used mrbs files.

[Ocean]

Updating MRBS will be great anyway. Thanks.

[Ocean]

I did not expect my plugin is much used and was appreciated for many users of MRBS and Joomla. Also that many Joomla users are using your MRBS.

Thanks for you great MRBS script.

[Anonymous]

I reaired your language.inc file without removed any line code and its works in latest joomla
Just changed above function name and order of the fun

[Campbell Morrison]

I have now namespaced the MRBS code so that there shouldn't be any clashes with Joomla! The changes have been committed to the default branch in changeset 96572ec1bb00.

[Theophilix]

Does this mean I can download https://sourceforge.net/projects/mrbs/files/latest/download and all changes are inside? How can I download only the files you changed and integrate them into my 1.5.0 installation with mrbs-joomla bridge?

[Campbell Morrison]

That link will just give you the 1.5.0 release. For the latest files in the default branch you will need to go to https://sourceforge.net/p/mrbs/hg-code/ci/default/tree/ and then "Download snapshot". You will need to install all the files in the release, not just the ones I have changed, as there have been many other changes since 1.5.0 and there will be inter-dependencies between files.

I can't guarantee that it will now work the Joomla bridge. There may be some minor changes necessary to the mrbs-joomla bridge. Ocean will be able to trst and advise.

[Theophilix]

Hello, thank you very much. The mrbs-joomla bridge works now. But: the layout/css is broken. See attached screenshot. Any ideas here? I would be so happy if it worked.

[Campbell Morrison]

Did you upload the new CSS files as well? If so, have you refreshed your browser? If you are still having problems can you (temporarily) add the following lines to the end of internalconfig.inc

error_reporting(-1);
ini_set('display_errors', '1');

and then look at the CSS file that is delivered to the browser. You can do this in Chrome by using More tools -> Developer tools and then looking at Sources. You want to look at mrbs.css.php - I suspect there will be some PHP error messages in there.

[Theophilix]

Hello, I found out that this is a Joomla-MRBS-Bridge issue. I solved it (for the workaround see: https://github.com/Syndes/Joomla-MRBS-Bridge/issues/3) Only one last thing: the logged in username in the right upper corner disappeared. How can I get it back?

[Campbell Morrison]

Have you got

$auth["session"]  = "jm";

set in your config file?

[Ocean]

Please see https://github.com/Syndes/Joomla-MRBS-Bridge/issues/3 for the solution.
This topic can be closed

[Ocean]

The bridge files are updated

[Theophilix]

Thanks to everyone, this issue can be closed.