RE: [Mrbs-general] Patch for duplicate bookings on change

[Rob C. <ro...@gl...>]

Bo,

Please can you educate me (us ?) how to apply patches.

regards,
rob.c

p.s. are the maintainers of this project still alive ?

> -----Original Message-----
> From:	Bo Kleve [SMTP:Bo...@un...]
> Sent:	Thursday, November 23, 2000 5:18 PM
> To:	mrb...@li...	
> Cc:	Claus Jeppesen
> Subject:	[Mrbs-general] Patch for duplicate bookings on change
> 
> >>I have the following problem - imagine that the reservation looks like
> >>this on, say, a Monday:
> >>
> >>Time        Person
> >>
> >>10:00       Claus Jeppesen
> >>10:30                -||-
> >>11:00       Maki Tamishuri
> >>11:30                -||-
> >>
> >>So Maki and I have a given room for 1 hour just after each other.
> However
> >>MRBS allows me to do the
> >>following: I can log on - and then edit my entry - MRBS will allow me to
> >>change the reservation from
> >>1 hour to 2 hours - thus overwriting Maki. The funny thing is: To delete
> >>my 2 hour reservation is a 2 step
> >>process (as if the database generated a new id when editing !?) : first
> I
> >>select and delete - then we are back at the situation before
> >>I edited my entry. Then I can delete my one hour entry. If I select the
> >>now empty slot
> >>at 10:00 and try to make a 2 hour reservation - that is denied. So I
> find
> >>a problem with editing existing
> >>entries.
> >
> >This all sounds like it's connected to the problem with duplicate entries
> >when a booking is changed three times. That part of edit_entry.php3 is
> not
> >working correctly. I looked at it yesterday night and saw changes to
> >"entry_type" in the "mrbs_entry" table when editing an entry... But I'll
> >have to look a bit more into that tonight.
> 
> There was no connection between the two problems... With the patch below I
> can't change one booking to intrude on an other bookings hours.
> 
> /BoK
> 
> *** updated/mrbs_sql.inc	Sun Nov  5 18:10:40 2000
> --- mrbs_sql.inc	Fri Nov 24 01:54:45 2000
> ***************
> *** 38,44 ****
>   		{
>   			$row = mysql_fetch_row($res);
>   			
> ! 			if($row)
>   				$sql .= " AND (repeat_id <> " . $row[0].
> ")";
>   		}
>   	}
> --- 38,44 ----
>   		{
>   			$row = mysql_fetch_row($res);
>   			
> ! 			if($row[0] > 0)
>   				$sql .= " AND (repeat_id <> " . $row[0].
> ")";
>   		}
>   	}
> 
> 
>  --------------------------------------------------
>  Bo Kleve                   Mail:  BoK@UNIT.LiU.SE
>  Linkoping University       Phone: +46 13 281761
>  Sweden                     Fax:   +46 13 284400
> 
> 
> _______________________________________________
> Mrbs-general mailing list
> Mrb...@li...
> http://lists.sourceforge.net/mailman/listinfo/mrbs-general