Menu ▾ ▴

#444 WordPress unsets $theme variable

Future_Requests
closed
nobody
wordpress (1) theme (1)
1
2020-10-11
2019-10-09
Johan Hattne
No

auth/cms/wordpress.inc loads wp-load.php from WordPress, which in turn loads wp-settings.php. wp-settings.php internally sets $theme, and unsets it when done. The effect is that once MRBS comes back from auth/cms/wordpress.inc, $theme is no longer set and any theme configured in MRBS's config.php.inc is ignored. The attached patch trivially addresses this issue, but there may very well be other variables similarly affected.

I half suspect that define('WP_USE_THEMES', false); is supposed to prevent this; if this is indeed the case, then this appears to be a WordPress issue instead.

1 Attachments
wp-theme.patch

Discussion

  • Campbell Morrison

    Campbell Morrison - 2019-10-10

    Many thanks for this. I have now committed the fix to the mrbs_17_branch (176619) and default (8e565c) branches.

    define('WP_USE_THEMES', false); wasn't supposed to prevent this. All it does is tell WP not to load a theme.

     

  • Campbell Morrison

    Campbell Morrison - 2020-10-11
    • status: open --> closed
     
Auth0 Logo