Menu

#357 CMake: Calls to check_type_size require CheckTypeSize included

1.32.x
closed-fixed
nobody
None
5
2023-09-27
2023-09-24
No

Hi, I noticed a small issue when attempting to use the vcpkg port of mpg123 on the wasm triplet. Something about that environment exposed that check_type_size is being used in the CMakeLists.txt without prior inclusion of CheckTypeSize. Fixing this led it to compiling and linking just fine.

Unsure if it's helpful but I've included the patch I'll be submitting to vcpkg :)

Thank you for you work on this library!

1 Attachments

Discussion

  • Thomas Orgis

    Thomas Orgis - 2023-09-24

    You get a hard error from that? My CMake on Linux doesn't make a sound. It misses the man-pages, though. I added your fix anyway, thanks.

     
    ❤️
    1
  • Joshua T Fisher

    Joshua T Fisher - 2023-09-24

    Yeah only when compiling for wasm with emscripten, it's very strange, I didn't see a peep on any of the other platforms.

    Thanks!

     
  • Thomas Orgis

    Thomas Orgis - 2023-09-27
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB