Menu ▾ ▴

#329 on Windows, _WIN32_WINNT is set unconditionnally

1.29.x
closed-fixed
nobody
None
5
2022-06-26
2021-12-28
No

on Windows, _WIN32_WINNT could be set by the user. Hence this warning

src/libout123/modules/win32_wasapi.c:9: warning: "_WIN32_WINNT" redefined
9 | #define _WIN32_WINNT 0x601
|
<command-line>: note: this is the location of the previous definition</command-line>

What about something like :

#if  defined(_WIN32_WINNT)
# if _WIN32_WINNT < 0x0601
#  error "wrong _WIN32_WINNT value"
# endif
#else
# define _WIN32_WINNT 0x0601
#endif

?

Vincent Torri

Discussion

  • Thomas Orgis

    Thomas Orgis - 2021-12-30

    OK, I followed your suggestion and included that bit. The current snapshot (being regenerated just now) should be fine.

     
  • Thomas Orgis

    Thomas Orgis - 2022-06-26
    • status: open --> closed-fixed
     

Log in to post a comment.