#290 fix build on linux x86 with cmake

[David Callu]

fix build on linux x86 with cmake

cmake only check platform for i386 instead of i.86
_FILE_OFFSET_BITS is not defined in config.h

[Thomas Orgis]

Thanks. Though I want to stress that the cmake port is not intended to replace the autotools build for Linux. It's purpose is mainly to provide portability for esoteric build environments like MSVC and it's there because someone contributed it, like other ports.

One question I have: What is

#cmakedefine _FILE_OFFSET_BITS @_FILE_OFFSET_BITS@

doing when the value is set to OFF? Is it undefined, then?

[David Callu]

I use/fix the canon package of mpg123, and cmake build system is used to build on Linux/Macos/Windows

yes, according to cmake doc, _FILE_OFFSET_BITS is undefined if the variable set in CMake is considered a false constant by the if() command.

[Thomas Orgis]

Ah, yet another package manager;-) Well, just be prepared that you may have to fix up thinks like this from time to time if you use the CMake port.

I applied the patch now in svn. There are two other patches for the build machinery in the pipeline (see mpg123-devel list) … once these are settled, I guess it is time for 1.26.2. So far, I have to make bugfix releases only for build system tuning. So, that means many people are trying the package, but nobody finds bugs in the actual code … I guess that's good;-)