#268 Port to libsdl2

[Ross Burton]

libsdl 1.2 is dead upstream, mpg123 should be able to use libsdl2.

[Thomas Orgis]

Am Mon, 14 May 2018 16:41:32 -0000
schrieb "Ross Burton" burtonini@users.sourceforge.net:

libsdl 1.2 is dead upstream, mpg123 should be able to use libsdl2.

Funny thing: it is. You just need to change one line in configure.ac:

I just changed
PKG_CHECK_MODULES(SDL, sdl, output_modules="$output_modules sdl" HAVE_SDL="yes", HAVE_SDL="no" check_failed=yes)
into
PKG_CHECK_MODULES(SDL, sdl2, output_modules="$output_modules sdl" HAVE_SDL="yes", HAVE_SDL="no" check_failed=yes)
and things worked.

The API did not change. The main question for me is now if I should
introduce the output module sdl2 or have sdl depend on either SDL1 or
SDL2 behind the scenes.

[Ross Burton]

Yes I suspected the port would be trivial, there was only one change to audio processing (buffer isn't cleared for you). I'd argue that as libsdl1 is dead, the sdl port should be for sdl2.

[Thomas Orgis]

I should not forget this for the next release. Easy enough change.

[Thomas Orgis]

Note: next release means 1.26.0, not 1.25.x.