#36 0.6.0 has many clang compiler warnings

[Yuri]

/usr/ports/science/molsketch/work/Molsketch-0.6.0/libmolsketch/atom.h:63:10: warning: 'paint' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget* widget);
         ^
/usr/ports/science/molsketch/work/Molsketch-0.6.0/libmolsketch/atom.h:67:10: warning: 'setCoordinates' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void setCoordinates(const QVector<QPointF> &c) ;
         ^
/usr/ports/science/molsketch/work/Molsketch-0.6.0/libmolsketch/graphicsitem.h:65:18: note: overridden virtual function is here
    virtual void setCoordinates(const QVector<QPointF>& c) = 0;
                 ^
/usr/ports/science/molsketch/work/Molsketch-0.6.0/libmolsketch/graphicsitem.h:60:10: warning: 'mousePressEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void mousePressEvent(QGraphicsSceneMouseEvent *event);
         ^
/usr/local/include/qt5/QtWidgets/qgraphicsitem.h:436:18: note: overridden virtual function is here
    virtual void mousePressEvent(QGraphicsSceneMouseEvent *event);
                 ^

FreeBSD

[Hendrik Vennekate]

Whoa that was > 9k warnings... Fixed them and pushed to GitHub. Thanks for reporting!
Do you need me to do a re-release?

[Yuri]

Thank you for fixing the warnings!
No need for a release.

[Hendrik Vennekate]

Ok, can I close this then and we'll see if I missed anything in the next release? (I only enabled the corresponding compiler option for gcc and did not actually try with clang...)

[Hendrik Vennekate]

Just a quick update: 0.7.0 has been released in the meantime and hence I'm going to close this -- assuming that clang does not generate any more warnings.