Re: [Mjpeg-developer] [PATCH] zoran: Fix a warning on x86_64

[Trent P. <xy...@sp...>]

On Wed, 30 May 2007, Jean Delvare wrote:
> On Fri, 25 May 2007 10:27:19 -0700 (PDT), Trent Piepho wrote:
> > On Fri, 25 May 2007, Jean Delvare wrote:
> > > My patch wasn't introducing these problems, but I agree we can fix them
> > > while we're there and your proposal looks good. Here's an updated
> > > patch, thanks.
> >
> > I've put it into my queue.  Ronald, this one ok too?  I don't want other
> > peoples' acks to a patch just because I think they should be ok with it.
> >
> > If you're going to keep making patches, I don't suppose you could get the
> > latest version of v4l-dvb from the hg repository and use the submitting
> > patches instructions.  It would make the patches easier to apply.
>
> I won't be sending that many zoran patches, I only have two more
> pending, and I am keeping track of your other zoran patches so I think
> I am more or less in sync with what you have. But if it makes it easier
> for you, I can certainly base my patches on the v4l-dvb repository. You
> just have to tell me how to do it, as I don't know anything about hg. I
> have a copy of the repository but I can't see any of the recent changes
> we've been discussing there.

The code in the v4l-dvb repository isn't exactly the same as the kernel code
so I can't simply import your patches.

The changes so far aren't in the main repository yet.  If you pull from
http://linuxtv.org/hg/~tap/zoran you'll get everything I have in my queue.

This is from the README.patches file:
3. Mercurial trees used for v4l/dvb development
   ============================================

V4L/DVB driver development is hosted at http://linuxtv.org. There are a
number of trees there each owned by a developer of the LinuxTV team.

There is also a master mercurial repository, owned by the subsystem
maintainer, available at:
	http://linuxtv.org/hg/v4l-dvb

When a developer believes that he has patches done to be merged, he
sends a request tthe developers' mailing list and to the subsystem
maintainer. The patches are analized and, if they look ok, merged into
the master repository.

It is good practice that each developer will have at least one tree
called 'v4l-dvb', which keeps their patches, and periodically update
this tree with the master tree's patches.

4. Community best practices
   ========================

>From accumulated experience, there are some basic rules that should
be followed by the community:

a) Every developer should follow the "rules of thumb" of kernel development
   stated at Linux source code, especially those stated at kernel,
   under:
	Documentation/HOWTO
 	Documentation/SubmittingPatches
b) All commits at mercurial trees should have a consistent message,
   describing the patch. This is done by using:

	make commit

   This will run some scripts that check changed files, correct
   bad whitespace and prepare the last Signed-off-by: field, as
   described below. A good comment will have a brief
   description at the first line, up to 68 characters wide, a blank
   line, the patch author's name on the third line, a blank line, and
   then a brief description, with no more than 80 chars per line, e. g.:

	   This patch does nothing

	   From: nowere <nowere noplace org>

	   This is just a sample commit comment, just for reference purposes.

	   This "patch" does nothing.

	   Signed-off-by: nowere <nowere noplace org>

   All lines starting with # and all lines starting with HG: will be
   removed from the mercurial commit log.

   *WARNING* Be careful not to leave the first line blank, otherwise hg
   will leave subject blank.

   From: line shouldn't be ommited, since it will be used for the
   patch author when converting to -git.

c) For "make commit" to work properly, the HGUSER shell environment var
   should be defined (replacing the names at the left):

	HGUSER="My Name <myemail mysite com>"

   If HGUSER is not set, then, if present, the username defined in the
   user's ~/.hgrc file will be used.  Use of the .hgrc file is preferred
   over the HGUSER variable according to the hg man page.

   This name will be used for both the user metadata in the Hg commit
   log and the initial values of the "From:" and "Signed-off-by:" lines
   in the pre-made commit message.

   It is also possible to use a different login name at the site
   hosting the repo, by using:

	CHANGE_LOG_LOGIN=my_log_name

   With this, "make push" will use my_log_name, instead of the name for
   the current unix user.

   Don't forget to export the vars at shell, with something like:

	export CHANGE_LOG_LOGIN HGUSER

   It is strongly recommended to have those lines in .bashrc or .profile.