Re: [Mjpeg-developer] DV PAL YV12 - [was: 1.6.3 RC1 ready for testing]

[Steven M. S. <sms@2BSD.COM>]

On Wed, 8 Jun 2005, Luca Bonissi wrote:

> Now I have always this warning:
> 
>   ++ WARN: [lav2yuv] Input file test4.mov is not in  JPEG 4:2:2 or 4:2:0
>            format

	I was waiting for you to notice that would happen...

> But I think it is useless (and maybe confusing) since libdv output is
> always 4:2:2 or 4:2:0. I place an extra check: if the source is from
> libdv, it does not print the warning.
	
	I think the correct thing to do is fix the underlying problem by
	setting the 'lav_file->chroma' structure member to CHROMA422 or
	CHROMA420.  It's better I think to set that so that the rest
	of lavtools has a meaningful and correct value value to use.

	Rather than suppress the error message (which is a valid warning 
	saying that the 'chroma' type was not set correctly) I would rather
	set the correct value in ->chroma

	Could you redo the paldv patch but set the value rather than specialcase
	the printing of the warning message?

	The lav2yuv patch is ok - I'll commit that in a minute or two.

> I include also a little patch for lav2yuv: it adds the option "-x" that
> exchanges fields (very useful for broken avi header from MJPEG cards).

	Ok - I think that could also be done with 'yuvcorrect'.

	Cheers,
	Steven Schultz