From: SourceForge.net <no...@so...> - 2005-06-21 18:57:12
|
Patches item #1188649, was opened at 2005-04-23 19:04 Message generated for change (Comment added) made by julienlecomte You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1188649&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: runtime Group: None Status: Open Resolution: None Priority: 5 Submitted By: Julien Lecomte (julienlecomte) Assigned to: Nobody/Anonymous (nobody) Summary: mingwex - runtime - get_opt.c Initial Comment: Bug or feature ? Compiling under MinGW an app that uses getopt_long and long options will result that partial matches will succeed in being declared as correct. In other words : "myapp.exe --silent" and "myapp.exe --sile" both result in being in silent mode (while the 2nd should print an error message) This patch fixes get_opt.c ---------------------------------------------------------------------- >Comment By: Julien Lecomte (julienlecomte) Date: 2005-06-21 20:57 Message: Logged In: YES user_id=827175 Thanks for the doc, removing patch. ---------------------------------------------------------------------- Comment By: Julien Lecomte (julienlecomte) Date: 2005-06-21 20:57 Message: Logged In: YES user_id=827175 Sorry, the patch isn't acceptable. Hopefully there has been appropriate explanation prior to this action. If not or if you have further questions then please ask them at min...@li... and be sure to include the patch # in the subject for reference. ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2005-06-21 17:55 Message: Logged In: YES user_id=823908 Are you sure of your facts here. AIUI, this patch will *break* correct getopt_long behaviour. Quoting from the getopt(3) manpage on my GNU/Linux box: The getopt_long() function works like getopt() except that it also accepts long options, started out by two dashes. Long option names may be abbreviated if the abbreviation is unique or is an exact match for some defined option. A long option may take a parameter, of the form --arg=param or --arg param. End quote. Thus, for a long argument defined as "--silent" it is perfectly correct for "--sile" to match, provided that abbreviation is not ambiguous. If this patch does as advertised, it will break behaviour which is correct, as documented. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1188649&group_id=2435 |