From: Lennart B. <len...@st...> - 2005-10-12 12:53:14
|
Keith MARSHALL wrote: >Your tests aren't sufficiently portable, to let that happen on >any non-GNU flavour of UNIX. >... > > >>The output from these tests also contains uname -a and >>diff --version to make this easier. >> >> > >`uname -a' is ok, (should be ubiquitous), but `diff --version' >will choke with an "illegal option" exception, if I try to run >it on SunOS/Solaris; similarly `diff -u' is not universally >supported, (and will also choke on SunOS/Solaris). `diff -c' >is more portable, (SunOS/Solaris *does* support it), but for >ultimate portability you need to run a bare diff command >*without* options. > > Would "diff --version 2>&1 || echo Not GNU diff, unknown version" be a useful solution? >You should also be aware that the shUnit test framework you have >employed will, itself, crash the standard shell on many current >(and older) BSD systems; (this is because the ${varname:-value} >construct is not permitted -- only ${varname-value} is allowed). > > That is a pitty. I do not want to change this myself but can try to carry it back to the maintainers. However I believe there main target is Posix compliant systems. (And I should not change it because I do not know this stuff that well!) Kind regards, Lennart |