From: Luke D. <cod...@ho...> - 2005-11-01 15:00:17
|
----- Original Message ----- From: "Chris Sutcliffe" <iro...@wa...> To: <min...@li...> Sent: Sunday, October 30, 2005 10:34 AM Subject: Re: [MinGW-dvlpr] OBJBASE_H_? > Hey, > >> gets us back to the objbase.h header guard before this >> 2004-04-24 Luke Dunstan <in...@us...> >> * include/objbase.h (_OBJBASE_H_): Define. >> >> which was followed by this incorrect reversion of the above >> 2005-09-08 Dimitri Papadopoulos <pap...@us...> >> * include/objbase.h: Avoid double header guard. > > Since the removal of the proper #define caused compilation failures, I > figured it was just a matter of correcting what appeared to be the > incorrect #define. If, for some reason, it's better to use _OBJBASE_H_, I > have no problem with it, as long as the #ifndef is also changed to suit. Your patch was a correct fix to the problem caused by Dimitri's patch. The issue is that it effectively also reverted my patch: if you look at the version from before Dimitri's patch then you will understand. It defines BOTH OBJBASE_H_ and _OBJBASE_H_ but uses #ifndef OBJBASE_H_. Luke > >> What was reason for your patch to add _OBJBASE_H_? Is that reason still >> valid? > > Let me know... I uploaded the new release so as to mitigate what I felt > was a serious flaw (since it caused compilation failures). > > Thanx! > > Chris |