From: Danny S. <dan...@cl...> - 2003-12-02 08:48:06
|
Mohan wrote > Hi People, > > Ranjit: thanks for your feedback. This is exactly the > kind of feedback I was looking for. > > MinGW people: I'm forwarding Ranjit's comments pertaining > to this: > > http://gcc.gnu.org/ml/java-patches/2003-q4/msg00438.html > > No one has commented on the updated patch yet. > Danny and Earnie commented on the original patch, which > had licensing issues. > > I like the --with-win32-nlsapi suggestion. If I make this > change, does anyone have any objections or further feedback > concerning this? Are there any other folks I should get > approval from? If I don't hear from anyone soon, I'll > assume you're so awestruck by the patch that you're at a > loss for words. How many w32api calls are involved? If not too many, couldn't we write our own libminunicows.a that takes the wide char calls (and dependent on msvcrt export _os_ver) just calls the NT W function or wraps the A function with U-A-U translation). I think that would mean that you could get rid of UnicodeToNative and NativeToUnicode from libgcj itself and just use them in libmiunicows.a. It would also mean only one libgcj.a to distribute. This would make it relatively simple to get rid of all the U-A-U translation stuff eventually. Danny > -- Mohan > http://www.thisiscool.com/ > http://www.animalsong.org/ > > ------- Start of forwarded message ------- > From: Ranjit Mathew > Subject: Fwd: Re: [PATCH] [MinGW] for Review: Add UNICODE support to MinGW libgcj (UPDATED) > Date: 12/1/2003 9:21:20 PM > > Mohan Embar wrote: > > - whether I'm allowed to introduce a new libgcj configure > > switch (--enable-libgcj-mingw-osapi) and if so, whether it > > is aptly named > > Wouldn't "--with-win32-nlsapi={ansi,unicode,unicows}" > be better? This is because IMHO the "--with" style > more accurately reflects what you want to do and > because this option can possibly be used one day to > decide what to use for libstdc++-v3 on MinGW (and > possibly other libraries). > > With the above, you'll also have to get a nod > from MinGW and Cygwin developers, though I don't > expect them to pour vitriol on you for this. :-) > > > > - whether the AC_DEFINE MINGW_LIBGCJ_UNICODE > > is aptly named > > FWIW, I agree with Tom that the "LIBGCJ" part > in the name is redundant because of where it > gets defined. > > I'm sorry, but I haven't had the time to comb > through your patch in its entirety (but apparently > had enough time to participate in flame-wars ;-)). > > Ranjit. > > -------- End of forwarded message -------- > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > MinGW-dvlpr mailing list > Min...@li... > https://lists.sourceforge.net/lists/listinfo/mingw-dvlpr |