From: Keith M. <kei...@us...> - 2018-01-18 16:18:33
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 18/01/18 14:56, Eli Zaretskii wrote: >> FWIW, I built this as follows:-- > > It is strange that such complications are needed in this case. I > guess the root cause is gmp.h? Yes. GMP itself insists that it be built with either: --enable-static --disable-shared or: --enable-shared --disable-static No other combination is permitted; nor apparently, is omission of any one option, or both, within either pairing. In the first case, the installed gmp.h is generated with hard-coded: #define __GMP_LIBGMP_DLL 0 while in the second, this becomes: #define __GMP_LIBGMP_DLL 1 > If so, perhaps it would make sense to release a version of GMP that > doesn't have this problem in that header? TRT would be to be to have a user defined feature test, (which is what my patch effectively does, although a user defined feature test macro should not be named with double initial underscores). Unfortunately, comments within gmp.h indicate that GNU MP maintainers are opposed to placing any onus on users, to define such a feature test macro, so such a solution would require us to maintain, in perpetuity, a local patch to correct this anomaly for all future GMP releases. I'm reluctant to embark on such a course, but unless the upstream GMP maintainers can be persuaded to see the light, it may become necessary. If we are to adopt any such feature test, I'd prefer it to exist in a MinGW specific namespace, and not specific to GMP, but rather to direct choice between static and dynamic linking for any libraries which offer that choice. Any suggestions for a suitable macro name? - -- Regards, Keith. Public key available from keys.gnupg.net Key fingerprint: C19E C018 1547 DE50 E1D4 8F53 C0AD 36C6 347E 5A3F -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJaYMjcAAoJEMCtNsY0flo/aHAP/jqxFuq/wHgUkRqd2O2O3qrN ykG5glQj3whLWxb6q71WbpOxqG7fr/g3HYV0KIQGzIGP604vnk11t0xHn4crLH9z fTXGpqLCgEdOMSDbAOqPtWwt4d+SrBbMyNzCiivIP6NCZMio3qUwyW4iuvAmIGpy dOCXHj4PJ+JS+elXcexNUBOC247T/q9ymqIAGzfxJdAknG5CADw1sKL3zTzf/m66 LNglkUoFAkX83oEuH6Bz+0Obv56JsyiI3Fe3eAzlDI3QLZJIK5YPmXNNfUDYxmZZ 8IsUZgfXN41HjKw9Xy7ob+IHHbtoBVALSz8VcD9uW2FqNQuw8oedwnPoZjXsvHWb HksuyRZNVuVf7Rmmt0No4BQYsZaEomxj/PrWy6nFaL6CwhN7zAbBDPFdHKT0U5wP EwmMHbqvxznl8eHgDjbwOLEP57yWuNZZbzApDgwUs/tO0UwnUG6ukAdSgCgQlsLT QTu+3WURkF+dmNRCJKfS61ORNchLXivMLMmD1gwGvyx5/GucuMYhsIkH9Bp53rxK dt6U3HzfN7F3nsr40uYi72iiMdZulBlNklPNqMQsyXcglGbaJF6PisEyw5sNyCQt kiuqVZ3uif11PLKSLhM5v62rfUaHB8CC3AEGF2k0QtlFHB7pIunDVUddMYt5IbqH YRbMcdZahYPVWZ447FKd =5kiC -----END PGP SIGNATURE----- |