From: Keith M. <kei...@us...> - 2012-10-29 22:48:53
|
On 23/10/12 16:23, Keith Marshall wrote: > On 21/10/12 15:05, Earnie Boyd wrote: >>> I still have my Mercurial sandbox, with master branch recording the >>> state of CVS HEAD at the time, and this development on a feature branch, >>> so I can easily create a patch relative to that old CVS state, if you'd >>> like that? >> >> This is what I expected. > > Okay, but I'd like to review it anyway, before I post it. I've looked through it again, and made some last minute adjustments, pursuant to writing up the ChangeLog. It hardly seemed worth the effort of doing that, while relating it to an obsolete code base... >>> If you'd like me to rework it, relative to your current WSL state, that >>> will take me a bit longer. >> >> So that I can do this. ..so I've gone ahead with preparation of a patch against your 4.0-dev branch of mingw.org-wsl. On the way, I've come up with the attached three interim patches: * wsl-20121029-1.patch Adds Mercurial hooks (.hgsub, .hgignore) * wsl-20121029-2.patch Aligns .gitignore with .hgignore (per prior discussion of .gitignore on this list) * wsl-20121029-3.patch Fixes the critical omission of CC define from Makefile.in; (without this, I cannot build WSL on my Linux host). Of these, 1 and 3 are mandatory, and 2 is recommended. I could push them myself, but you may prefer to do it; if I do, the gitlink for the build-aux submodule is likely to disappear from origin, since there has not yet been any satisfactory resolution of my hg-git but report. Following the adoption of (at least) the third of the above patches, you may wish to apply: * wsl-20121029-4.patch Resolves bug #3482704, item #2. When this post shows up in the gmane archive, I'll also attach this latter patch to the bug ticket, with a cross-reference to this thread. > I do have some reservations, (mostly cosmetic, but some possibly > legal), concerning the changes you've made to date... I'd expected some response to this aspect of my previous post, by this time; perhaps you just need more time to consider? -- Regards, Keith. |