From: Erwin W. <wat...@xs...> - 2012-04-03 19:10:06
|
Charles Wilson schreef, Op 2-4-2012 3:23: > On 3/30/2012 8:59 AM, Keith Marshall wrote: >> If you want your own documentation and/or licence files to supplant the >> corresponding files from cygutils, then you also need to update their >> component specifications accordingly. It seems to me, particularly in >> the case of the mingw32-cygutils package, that you could/should adopt >> everything, and allow that original package to disappear, but I'd like >> to have Chuck's opinion before just jumping in. > > I think the existing *-cygutils.xml files should be updated as in the > attached patch, which removes all mention of *-cygutils-dos2unix ... > thus letting the new *-dos2unix.xml files "take over". > > Also, as msys-cygutils-dos2unix WAS part of > <affiliate group="MSYS Base System" /> I have added this to msys-dos2unix.xml > I believe that the new msys-dos2unix should ALSO be a part of that. > Similarly, msys-base.xml should be updated as attached (although the > alias in the new msys-dos2unix package means that msys-base doesn't > NEED to be changed, it's better to be explicit and not rely on the > alias). > >>>> What are the next steps? >> >> Replace the issue attributes in your current files with a generic issue >> template, of the form @YYYYMMDDNN@, and integrate them into mingw-dist. >> I guess it would make sense for me to grant you CVS access, if you are >> happy to manage that yourself? >> >>> Are the xml files correct now? >> >> They look very close to it, AFAICS. I'd rather hoped that Chuck might >> have chimed in though, since you are supplanting his packages. > > Actually, if we are convinced that things are copacetic (with the > attached patches and the above-mentioned changes to the new xml > files), I don't mind doing the initial mingw-dist integration; we can > then leave the mingw-dist *updated* to Erwin when/as he releases new > versions in the future. That's fine with me. > > Basically, it boils down to adding the new files to the appropriate > package list xml: > > msys/msys-package-list.xml > mingw32/mingw32-package-list.xml > > ...and adding a changeLog entry. (After building, the */issue.log > files will be modified automatically, and those changes should be > checked in. But that should only be done once, by the final committer > for that change.) > > However, it would be great if... > >>> Do the cygutils xml files need to be edited? >> >> Yes. References for the components you are supplanting need to be >> removed, since your new dos2unix.xml will take "ownership" of them. > > See attached patches. > >>> Can I do the testing? >> >> Sure. Confirm that you can 'mingw-get upgrade ...' from an existing >> cygutils installation, with proper substitution of your own components, >> and that 'mingw-get show mingw32-dos2unix-bin' (for example), reflects >> the correct package status, (particularly the 'Installed Version' and >> 'Repository Version' notifications), when you run it both before and >> after the 'mingw-get upgrade ...', and post your results here. > > ...Erwin could verify this first. I will do this. It may take some time. I have to confess I never used mingw-get until now. I still did manual install... best regards, -- Erwin Waterlander http://waterlan.home.xs4all.nl/ |