From: Erwin W. <wat...@xs...> - 2012-02-23 17:04:16
|
Op 22-2-2012 23:29, Keith Marshall schreef: > On 22/02/12 18:59, Erwin Waterlander wrote: >> The current mingw-cygutils-dos2unix package ... > The current package is called "mingw32-cygutil-dos2unix"; I assume your > "mingw-..." is an accidental omission, but just in case, you need to > > s/mingw/mingw32/g > > in all instances please. I meant "mingw32". > >> ... has one alias "mingw-dos2unix". > That's not what I see: > > <package name="mingw32-cygutils-dos2unix" alias="cygutils-dos2unix"> You are right. Actually I was looking at the msys version of the cygutils xml file when I wrote that: <package name="msys-cygutils-dos2unix" alias="msys-dos2unix"> >> The name of the new package is "mingw-dos2unix". > That needs to be "mingw32-dos2unix", so you may rewrite the header as: > > <package name="mingw32-dos2unix" > alias="dos2unix cygutils-dos2unix mingw32-cygutils-dos2unix"> > > (You are allowed only one "alias" attribute, but it may specify multiple > aliases, separated by spaces). Because there is an msys version and a mingw32 version, I was thinking to omit the "dos2unix" alias. A user will have to select either msys-dos2unix or mingw32-dos2unix. So what I propose now is: For the msys version: <package name="msys-dos2unix" alias="msys-cygutils-dos2unix"> For the mingw32 version: <package name="mingw32-dos2unix" alias="mingw32-cygutils-dos2unix cygutils-dos2unix"> This way it stays backward compatible. I could add an "dos2unix" alias to the latter, making the mingw32 version the default when somebody installs 'dos2unix'. >> Where should I upload the new files? The current cygutils-dos2unix >> package resides under 'Extension'. Should I put them under >> Extension/dos2unix/5.3.2/. Or, because it's a contributed package,under >> Contributed/dos2unix/5.3.2/ > Keeping it as an "extension" package seems best to me. > I have uploaded the package files under MSYS/Extension and MinGW/Extension. Before I upload the xml files, does Charles need to modify the xml files for cygutils? regards, -- Erwin Waterlander http://waterlan.home.xs4all.nl/ |