Re: [Mingw-users] Msys-perl vs EBADF on fclose()

[Earnie <ea...@us...>]

Charles Wilson wrote:

> 
> The change to the msys dll was a one-liner:
> 
> Index: winsup/cygwin/syscalls.cc
> ===================================================================
> RCS file: /cvsroot/mingw/msys/rt/src/winsup/cygwin/syscalls.cc,v
> retrieving revision 1.18
> diff -u -p -r1.18 syscalls.cc
> --- winsup/cygwin/syscalls.cc   28 Dec 2009 22:07:32 -0000      1.18
> +++ winsup/cygwin/syscalls.cc   28 Mar 2011 23:35:59 -0000
> @@ -507,7 +507,6 @@ _close (int fd)
>      {
>        SetResourceLock (LOCK_FD_LIST,WRITE_LOCK|READ_LOCK," close");
>        res = cygheap->fdtab[fd]->close ();
> -      fsync(fd);
>        cygheap->fdtab.release (fd);
>        ReleaseResourceLock (LOCK_FD_LIST,WRITE_LOCK|READ_LOCK," close");
>      }
> 

A strong case has been made for this change but the fact is the perl
code is still wrong based on the documented function of fclose.  With
this statement I am not saying this patch should not be applied to MSYS,
in fact, I think it should.  Patches to resolve the issue in perl should
be made upstream as well, correct?

-- 
Earnie
-- http://www.for-my-kids.com