[Mingw-notify] [ mingw-Patches-2978078 ] mingw-get: Avoid a jump over initialization issue

[SourceForge.net <no...@so...>]

Patches item #2978078, was opened at 2010-03-28 16:01
Message generated for change (Comment added) made by cstrauss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2978078&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Cesar Strauss (cstrauss)
Assigned to: Nobody/Anonymous (nobody)
Summary: mingw-get: Avoid a jump over initialization issue

Initial Comment:
This patch fixes the following compiler error with MinGW GCC 4.4.0/4.5.0:

g++ -c -D DEBUGLEVEL=0 -I ../src/mingw-get/src -I ../src/mingw-get/src/pkginfo -I ../src/mingw-get/tinyxml -g -O2 -o tarproc.o ../src/mingw-get/src/tarproc.cpp
../src/mingw-get/src/tarproc.cpp: In member function 'virtual int pkgTarArchiveProcessor::Process()':
../src/mingw-get/src/tarproc.cpp:256: error: jump to case label
../src/mingw-get/src/tarproc.cpp:247: error:   crosses initialization of 'char* p'


----------------------------------------------------------------------

>Comment By: Cesar Strauss (cstrauss)
Date: 2010-03-29 19:34

Message:
> Would simply enclosing
> the offending initialisation, and the following `while' loop in braces
fix
> it for GCC-4.x?

Indeed it does.

> Either way, I have a significant tarproc.cpp change set almost ready
for
> check-in, so I'll address this at the same time.

Sure. For reference, I attach a new patch with the above change.


----------------------------------------------------------------------

Comment By: Keith Marshall (keithmarshall)
Date: 2010-03-29 09:50

Message:
Thanks Cesar,

GCC-3.4.5 doesn't seem to see this as an error.  Would simply enclosing
the offending initialisation, and the following `while' loop in braces fix
it for GCC-4.x?

Either way, I have a significant tarproc.cpp change set almost ready for
check-in, so I'll address this at the same time.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2978078&group_id=2435