Menu
▾
▴
[Mingw-notify] [ mingw-Patches-2673182 ] Adding basic support for DirectShow
|
From: SourceForge.net <no...@so...> - 2009-11-24 16:42:31
|
Patches item #2673182, was opened at 2009-03-08 21:49 Message generated for change (Comment added) made by keithmarshall You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2673182&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api >Group: License conflict >Status: Closed >Resolution: Rejected Priority: 5 Private: No Submitted By: Thierry Bastian (thierryoslo) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: Adding basic support for DirectShow Initial Comment: I added the necessary enum, define, typedef... I also corrected some typos in the current headers. I know it doesn't exactly fulfill the requirements for a patch to be included but please review it. It is not the ful DirectShow 9 support that I added. Just the things missing for Phonon (which is directshow based on Windows). Mingw is the default compiler for KDE and QtCreator. So being able to compile support for multimedia out of the box would be awesome for us. ---------------------------------------------------------------------- >Comment By: Keith Marshall (keithmarshall) Date: 2009-11-24 16:42 Message: > So basically, I compiled the source with ms sdk and then did something > like: So basically, you just disqualified your patch. This doesn't even qualify as reverse engineering; it's just an indirect way of reading a Microsoft header, no different from just opening it with a text editor and copying it. You have to use publicly available *documentation*, not MS headers as your reference resource. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2009-11-24 15:25 Message: Sorry, this appears to be reverse engineering to me. I don't think we can accept this patch. ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-11-24 11:54 Message: So basically, I compiled the source with ms sdk and then did something like: GUID guid = <the value>; printf("0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x", guid.Data1, guid.Data2, guid.Data3, guid.Data4[0], guid.Data4[1], guid.Data4[2], guid.Data4[3], guid.Data4[4], guid.Data4[5], guid.Data4[6], guid.Data4[7]); And then I reused those values. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2009-11-24 11:48 Message: Just so we understand the source of your patch, when you say "I just used a little printf to get the values", can you please provide the same code used? ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-11-24 09:20 Message: So for the GUIDs, I just used a little printf to get the values qnetwork.h IAMMediaContent http://msdn.microsoft.com/en-us/library/dd319638(VS.85).aspx IAMNetworkStatus http://msdn.microsoft.com/en-us/library/dd319732(VS.85).aspx medparam.h MP_CURVE_TYPE http://msdn.microsoft.com/en-us/library/dd390743(VS.85).aspx MP_TYPE http://msdn.microsoft.com/en-us/library/dd390746(VS.85).aspx MP_PARAM_INFO http://msdn.microsoft.com/en-us/library/dd390745(VS.85).aspx MP_ENVELOPE_SEGMENT http://msdn.microsoft.com/en-us/library/dd390744(VS.85).aspx IMediaParamInfo http://msdn.microsoft.com/en-us/library/dd406964(VS.85).aspx IMediaParams http://msdn.microsoft.com/en-us/library/dd406971(VS.85).aspx ddraw.h (sorry some interfaces are in the offline msdn doc) DDCOLORKEY http://msdn.microsoft.com/en-us/library/aa911328.aspx DDBLTFX ms-help://MS.MSDNQTR.v90.en/directshow/htm/ddbltfx.htm (this one is only in the offline msdn, the online version is strangely shorter, maybe DX9...) DDBLTBATCH ms-help://MS.MSDNQTR.v90.en/directshow/htm/ddbltbatch.htm (can't find it on the online msdn... strange) DDSCAPS http://msdn.microsoft.com/en-us/library/ms794242.aspx DDSCAPS2 http://msdn.microsoft.com/en-us/library/ms794233.aspx DDCAPS http://msdn.microsoft.com/en-us/library/ms907789.aspx DDPIXELFORMAT http://msdn.microsoft.com/en-us/library/ms794069.aspx DDSURFACEDESC http://msdn.microsoft.com/en-us/library/aa915440.aspx DDOVERLAYFX http://msdn.microsoft.com/en-us/library/aa911331.aspx IDirectDrawPalette ms-help://MS.MSDNQTR.v90.en/directshow/htm/idirectdrawpalette.htm IDirectDrawClipper ms-help://MS.MSDNQTR.v90.en/directshow/htm/idirectdrawclipperinterface.htm IDirectDraw ms-help://MS.MSDNQTR.v90.en/directshow/htm/idirectdrawinterface.htm IDirectDrawSurface ms-help://MS.MSDNQTR.v90.en/directshow/htm/idirectdrawsurfaceinterface.htm dmo.h DMO_PARTIAL_MEDIATYPE http://msdn.microsoft.com/en-us/library/aa920693.aspx DMO_ENUM_FLAGS http://msdn.microsoft.com/en-us/library/aa920678.aspx IEnumDMO http://msdn.microsoft.com/en-us/library/aa929881.aspx DMOEnum & DMOGetName http://msdn.microsoft.com/en-us/library/dd375499(VS.85).aspx dmodshow.h IDMOWrapperFilter http://msdn.microsoft.com/en-us/library/aa926261.aspx dshow.patch IMediaControl http://msdn.microsoft.com/en-us/library/dd390170(VS.85).aspx IBasicAudio http://msdn.microsoft.com/en-us/library/dd389532(VS.85).aspx IMediaPosition http://msdn.microsoft.com/en-us/library/aa931901.aspx IMediaEvent http://msdn.microsoft.com/en-us/library/dd406896(VS.85).aspx IFilterGraph http://msdn.microsoft.com/en-us/library/dd389989(VS.85).aspx IGraphBuilder http://msdn.microsoft.com/en-us/library/ms910581.aspx IReferenceClock http://msdn.microsoft.com/en-us/library/dd376925(VS.85).aspx IEnumFilters http://msdn.microsoft.com/en-us/library/aa928686.aspx IEnumMediaTypes http://msdn.microsoft.com/en-us/library/ms910541.aspx IEnumPins http://msdn.microsoft.com/en-us/library/dd376610(VS.85).aspx IPin http://msdn.microsoft.com/en-us/library/ms912308.aspx IMediaFilter http://msdn.microsoft.com/en-us/library/aa925414.aspx IBaseFilter http://msdn.microsoft.com/en-us/library/dd389526(VS.85).aspx IMediaSeeking http://msdn.microsoft.com/en-us/library/aa919887.aspx ICreateDevEnum http://msdn.microsoft.com/en-us/library/dd406743(VS.85).aspx IMediaSample http://msdn.microsoft.com/en-us/library/dd407001(VS.85).aspx IMemAllocator http://msdn.microsoft.com/en-us/library/dd407061(VS.85).aspx IAsyncReader http://msdn.microsoft.com/en-us/library/dd376085(VS.85).aspx IMediaEventSink http://msdn.microsoft.com/en-us/library/dd406901(VS.85).aspx IMemInputPin http://msdn.microsoft.com/en-us/library/aa921473.aspx IVMRImageCompositor9 http://msdn.microsoft.com/en-us/library/dd377381(VS.85).aspx IVMRFilterConfig9 http://msdn.microsoft.com/en-us/library/dd377365(VS.85).aspx IVMRWindowlessControl9 http://msdn.microsoft.com/en-us/library/dd390537(VS.85).aspx IVMRMixerControl9 http://msdn.microsoft.com/en-us/library/dd390457(VS.85).aspx AM_SEEKING_SEEKING_FLAGS http://msdn.microsoft.com/en-us/library/dd407038(VS.85).aspx + printf FILTER_INFO http://msdn.microsoft.com/en-us/library/dd375787(VS.85).aspx I hope this is enough information. If not don't hesitate to ask. It was a long thing to go back to all the docs I used back in the days. At least I'll know how to proceed for next time. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2009-11-23 20:01 Message: Thierry, Please don't make us go look for the information again. Provide exacting links to the documentation to which you found in MSDN. You submitted the patch with the documentation in hand and have first hand knowledge of where you found it. Thanks, Earnie ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-11-21 12:44 Message: I got the information from the documentation (msdn). ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2009-11-20 23:20 Message: What is the source for these patches (i.e. where did you get the information from)? ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-03-11 10:55 Message: I just created here the patch necessay to apply to the current CVS revision. I also added a few new files. All that is mostly to add support for new interface: - amvideo.h: fixed a typo - bdatypes.h: fixed a typo - control.h: - added typedef for OAFilterState - added DEFINE_GUID for IID_IBasicAudio, IID_IMediaControl, IID_IMediaEvent and IID_IMediaPosition - added interface declaration for IMediaControl, IBasicAudio, IMediaPosition, IMediaEvent - dshow.h: - remove the include of dsound.h id DSHOW_USE_AMAUDIO is not defined (dsound is not there) - added a missing comma - strmif.h: - added support for interfaces: IFilterGraph, IGraphBuilder, IReferenceClock, IEnumFilters, IEnumMediaTypes, IEnumPins, IPin, IMediaFilter, IBaseFilter, IMediaSeeking, ICreateDevEnum, IMemAllocator, IAsyncReader, IMediaEventSink - vmr9.h: - added missing semi-colon -added support for interfaces: IVMRImageCompositor9, IVMRFilterConfig9, IVMRWindowlessControl9, IVMRMixerControl9 The added files are there to add basic features (interfaces and struct declaration). If you need more info, don't hesitate. File Added: include.zip ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-03-09 16:03 Message: I've spent some more time today on it so that the content of the files is cleaner. Just tell me if you need more info or a real patch. ---------------------------------------------------------------------- Comment By: Thierry Bastian (thierryoslo) Date: 2009-03-09 16:01 Message: File Added: include.zip ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2673182&group_id=2435 |