[Mingw-notify] [ mingw-Patches-2854155 ] msys.bat w/ CR+LF replacement

[SourceForge.net <no...@so...>]

Patches item #2854155, was opened at 2009-09-08 08:27
Message generated for change (Comment added) made by keithmarshall
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2854155&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: msys
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: iysil (iysil)
Assigned to: Cesar Strauss (cstrauss)
Summary: msys.bat w/ CR+LF replacement

Initial Comment:
MSYS.BAT is broken on Windows 9x platforms because it uses UNIX style
(LF) line endings, which is incompatible with MS-DOS - the environment
that batch (.BAT) files use under Windows 95/98/ME.  When msys.bat is
invoked on these systems, it will return "Bad command or file name".

This solution, from the advice of Peter Hayward, is to save the file
with DOS-style CR/LF line endings.  This corrects the situation under
win9x and should pose no problem on NT/2000/XP/Vista/7 systems.

I included the standard `patchfile.diff' , but I'm also including the actual,
modified `msys.bat' file too.

----------------------------------------------------------------------

>Comment By: Keith Marshall (keithmarshall)
Date: 2009-09-09 15:10

Message:
> That's ridiculous...

FWIW, *this* project administrator is inclined to agree, (although I do
find your tone mildly offensive, both here and on the mailing list); it
would seem that the current MSYS maintainer concurs.

That MSYS-1.0.11 has been packaged with LF, rather than CRLF line endings
in msys.bat is a packaging bug.  It is trivially easy to correct, I see
absolutely no reason why we shouldn't do so, and Cesar, the current
maintainer has already agreed to address the issue.  I've no idea why
Earnie suggested we should do otherwise, on the grounds that you choose to
use a dinosaur OS; perhaps he was having a bad day.

Just for the record, msys.bat is stored in CVS with bare LF line endings. 
It has to be so, otherwise it may accumulate CR...CRCRLF endings on any
checkout..commit cycle initiated from a *nix working host, (as I use). 
Windows CVS clients are *expected* to convert to CRLF on checkout, but the
MSYS' CVS client doesn't do this -- something requiring care, (or
unix2dos), when packaging.

----------------------------------------------------------------------

Comment By: Cesar Strauss (cstrauss)
Date: 2009-09-09 12:46

Message:
MSYS.BAT in MSYS-1.0.10 does have CR/LF line endings. It got LF line
endings in 1.0.11 by some accident.
I will correct this.

Thanks,
Cesar


----------------------------------------------------------------------

Comment By: iysil (iysil)
Date: 2009-09-08 16:42

Message:
That's ridiculous.  Just because a business stops supporting a (mature)
product to bring in more revenue and lower (support) expenses, doesn't mean
that every developer in the world should follow suit - especially if the
application can remain backward compatible with just a few lines of code
submitted by someone else.

----------------------------------------------------------------------

Comment By: Earnie Boyd (earnie)
Date: 2009-09-08 15:54

Message:
I'm no longer working on MSYS.  If it were me I would close as invalid and
state that win9x is no longer supported.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2854155&group_id=2435