Re: [Mingw-users] Re: More patch 2.5.9 hacking

[Paul E. <eggert@CS.UCLA.EDU>]

"manubee" <ma...@wa...> writes:

> >> +#ifdef __MINGW32__
> >> +        mkdir (filename);
> >> +#else
> >> +        mkdir (filename,
> >> +           S_IRUSR|S_IWUSR|S_IXUSR
> >> +           |S_IRGRP|S_IWGRP|S_IXGRP
> >> +           |S_IROTH|S_IWOTH|S_IXOTH);
> >> +#endif
> >
> Apparently nobody reads what I'm posting, I'd rather go fishing :)
> I've already submitted a patch for this.
> I had no reply.

If the patch is what is quoted above, then it's not the right patch
for reasons that Eli Zaretskii already mentioned: we want to avoid
putting '#ifdef __MINGW32__' in the mainline code.

If it's some other patch then I must have missed it; sorry.

> The mkdir.m4 macro just _DOESN'T_WORK_. It always returns "no",
> while it should return "yes" under Windows.

Then the right thing to do is to fix the mkdir.m4 macro.  Why
isn't it working?

mkdir.m4 tries to compile both (mkdir (".", 0)) and (mkdir (".")).  If
the latter compiles but the former does not, mkdir.m4 concludes that
mkdir has only one argument.  What is wrong with that method?