[Mingw-notify] [ mingw-Patches-1599889 ] portmaker patch

[SourceForge.net <no...@so...>]

Patches item #1599889, was opened at 2006-11-20 19:31
Message generated for change (Comment added) made by borutr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1599889&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: portmaker
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Borut Razem (borutr)
Assigned to: Nobody/Anonymous (nobody)
Summary: portmaker patch

Initial Comment:
Hi,

I attached the portmaker patch with the following fixes:

* lib/mingwPORT.functions: win32path() - use cygpath if pwd -W fails, which is the case on cygwin
* src/portmaker.sh: corrected escaping
* template/mingwPORT.afterquestion: added brackets for proper grouping; the $ARCHIVE.log file was not created in previous version
* template/mingwPORT.configure: call win32path() which woks on msys and cygwin instead pwd -W which is msys specific
* template/mingwPORT.exports: export $CC and $CXX if they are not defined: as "gcc" and "g++" in case of mingw GCC compiler or "gcc -mno-cygwin" and "g++ -mno-cygwin" in case of cygwin GCC compiler

The patched version works on mingw + msys and on cygwin.

Borut


----------------------------------------------------------------------

>Comment By: Borut Razem (borutr)
Date: 2006-11-20 21:18

Message:
Logged In: YES 
user_id=568035
Originator: YES

I don't see why it shouldn't work on cygwin too. I can understand that the
primary goal is MSYS, but with small changes I made it works with cygwin
too and MSYS is not a required item in that case.

Maybe the problems is that I haven't mentioned clear enough that the
result of building on cygwin is "pure mingw" - by using "gcc -mno-cygwin"
compiler option, which means the the result is the same as building on
msys (actually it is not exactly the same because a different gcc versions
is used).

But it is your decision anyway. If you decide not to include cygwin
specifics, then ignore changes in lib/mingwPORT.functions and in
template/mingwPORT.exports. Changes in other files are not connected with
cygwin and I recommend to apply them.

Borut

----------------------------------------------------------------------

Comment By: Earnie Boyd (earnie)
Date: 2006-11-20 20:07

Message:
Logged In: YES 
user_id=15438
Originator: NO

* template/mingwPORT.configure: call win32path() which woks on msys and
cygwin instead pwd -W which is msys specific

Of course this is going to be MSYS specific.  MSYS is a required item. 
I'm going to let Keith make the final call on this patch.  I'm thinking
that we should reject it though.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1599889&group_id=2435