Menu

#60 winsock2.h has duplicate WSA* #defines

Known_bugs
closed-fixed
nobody
2001-08-01
2001-08-01
Anonymous
No

There are two sets of WSA* #defines in winsock2.h.
They
are identical in effect (the formal arguments have
different
names, but that is irrelevant). The patch below
removes
the first set. Would you apply it, please? Then, the
gcc -pedantic option can be used.

Thanks!

--- winsock2.h~ Wed Jun 6 13:07:34 2001
+++ winsock2.h Wed Aug 1 10:33:49 2001
@@ -497,13 +497,6 @@
int PASCAL gethostname(char*,int);
#endif /* ndef __INSIDE_CYGWIN__ */

-#define WSAMAKEASYNCREPLY(b,e) MAKELONG(b,e)
-#define WSAMAKESELECTREPLY(e,error)
MAKELONG(e,error)
-#define WSAGETASYNCBUFLEN(l) LOWORD(l)
-#define WSAGETASYNCERROR(l) HIWORD(l)
-#define WSAGETSELECTEVENT(l) LOWORD(l)
-#define WSAGETSELECTERROR(l) HIWORD(l)
-
typedef struct sockaddr SOCKADDR;
typedef struct sockaddr *PSOCKADDR;
typedef struct sockaddr *LPSOCKADDR;

Discussion

  • Danny Smith

    Danny Smith - 2001-08-01

    Logged In: YES
    user_id=11494

    I have removed second set of defines and committed change
    to SF CVS.

     
  • Danny Smith

    Danny Smith - 2001-08-01
    • status: open --> closed-fixed