#2249 lack of JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE constant in winnt.h

[Alexander Krisak]

Version of winnt.h from w32api-4.0.3-1-mingw32-dev.tar.lzma has no definition of JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE constant. I'm has prepared patch, that adds that definition. Can anybody apply this patch to main tree?

Thanks.

[Keith Marshall]

I have a number of problems with this ticket:

• You exceeded your authority, in assigning it to me; I'm tempted to reject it out of hand, for that reason alone.
• You provided no documentary evidence, (e.g. an MSDN link), to support your submission.
• You neglected to provide a ChangeLog entry.
• Your patch is against a discontinued development branch; (discontinued because it is broken, beyond any hope of repair).

Notwithstanding, I can easily find the MSDN link for myself, so will attend to the one line change, at my own convenience.

[Alexander Krisak]

In maillist I have seen, that you most active developer, who do almost all the stuff, so I have assigned ticket to you. I'm very sorry for inconvenience.

There is link to MSDN: https://msdn.microsoft.com/en-us/library/windows/desktop/ms684147(v=vs.85).aspx:

JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE 0x2000 - Causes all processes associated with the job to terminate when the last handle to the job is closed.

Is there any url where I can read policy for preparing patches to mingw? Sorry, I don't have many experience with that.

[Keith Marshall]

In maillist I have seen, that you most active developer, who do almost all the stuff, so I have assigned ticket to you.

The instructions, right at the top of the ticket submission form, are very explicit about which fields you should complete, and which you should not; the owner assignment is clearly stipulated as one you should not touch.

I'm very sorry for inconvenience.

It isn't so much inconvenience, as delay in processing; we will always prioritize assessment of unassigned tickets over those already assigned. If you assign it, it may well be overlooked, as this one was.

There is link to MSDN: https://msdn.microsoft.com/en-us/library/windows/desktop/ms684147(v=vs.85).aspx

Noted, thanks.

Is there any url where I can read policy for preparing patches to mingw?

http://www.mingw.org/wiki/SubmitPatches

This link appears in the navigation pane, at the left of every page on http://mingw.org; however, do note that the "Official CVS Repository" references are obsolete. Use the appropriate sources here instead; see ticket [#2338].

[Keith Marshall]

I committed [b0798d].