Menu

#1993 Building mingw-get: syntax error in src/verinfo.rc

INSTALLER
closed
None
Bug
fixed
Unknown
False
2013-06-21
2013-06-20
No

Originally reported by Earnie, as a side issue on [#1989].

Related

Issues: #1989

Discussion

  • Keith Marshall

    Keith Marshall - 2013-06-20
    • status: assigned --> open
    • Resolution: none --> limbo
     
  • Keith Marshall

    Keith Marshall - 2013-06-20

    This issue is caused by an incomplete definition of the VERINFO_PRODUCT_VERSION macro in make-time generated file verinfo.h. This macro is required to specify four comma separated integer values, two derived from the autoconf PACKAGE_VERSION assignment, and two from the content of the build.tag file, which is an optionally generated file. The incomplete VERINFO_PRODUCT_VERSION definition is generated when build.tag either does not exist, or is empty, resulting in omission of the second pair of mandatory values; this omission raises the syntax error.

    Ensuring that

    make build.tag
    

    is invoked, prior to the make which generates verinfo.h, allows the build to complete successfully. However, we want this to be an optional prerequisite; we do not want to declare it such that it becomes a mandatory prerequisite.

    The scripting which generates both verinfo.h and version.c has been reworked in [779318], to ensure that suitable values are substituted in the definition of VERINFO_PRODUCT_VERSION, when none are available from build.tag. This fixes the immediate issue; however, I am leaving the ticket open, pending resolution of a related issue, which may lead to a non-fatal malformation in the generated VERINFO_PRODUCT_VERSION_STRING macro, when CLI_RELEASE_CLASS is specified as an empty string.

     

    Related

    Commit: [779318]

  • Keith Marshall

    Keith Marshall - 2013-06-21
    • status: open --> closed
    • Resolution: limbo --> fixed
     
  • Keith Marshall

    Keith Marshall - 2013-06-21

    And [360d7f] fixes the issue of extraneous delimiters surrounding a zero length release classification within VERINFO_PRODUCT_VERSION_STRING. This completes the scope of remedial action required by this ticket.

     

    Related

    Commit: [360d7f]