Re: [Ming-dev] MP3 ID3 fix

[strk <st...@ke...>]

FYI, I tried adding ID3 tags to test/Media/audio01.mp3
which is used by test/Sound/test01.c and verified that
the SWF produced by it has the same SWF_DEFINESOUND
structure:

   Block type: 14 (SWF_DEFINESOUND)
   Block length: 695075
   
    CharacterID: 1
    SoundFormat: MP3
    SoundRate: 22 KHz
    SoundSize: 16-bit
    SoundType: Stereo
    SoundSampleCount: 1915776
     Mp3: SeekSamples 1663

Is that a sign of the bug your patch is trying to address
being already fixed in HEAD ?

--strk;

On Sat, Jul 24, 2010 at 04:12:44PM +0200, strk wrote:
> On Sat, Jul 24, 2010 at 07:07:01AM -0000, ham...@t-... wrote:
> 
> > The following untested patch (based on a working patch for an older version)
> > will just skip
> > an ID3 header of a mp3 file and thus avoid the problem.
> > I am using this with foreign files provided by trusted sources.
> 
> Do you mean it is _tested_ against the older version and untested
> against HEAD ? Which version are your tests against ? Do you feel
> like producing a testcase for this to put in our testsuite ?
> 
> --strk; 
> 
>   ()   Free GIS & Flash consultant/developer
>   /\   http://strk.keybit.net/services.html
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> _______________________________________________
> Ming-devr mailing list
> Min...@li...
> https://lists.sourceforge.net/lists/listinfo/ming-devr

-- 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html