Using the library in a commercial application

[Yakir Dorani]

Hi,

I rebuilt the source code in Debug in order to get the untested interfaces and made the following changes:

1.
Added this method to the IMFSourceReader interface:

    [PreserveSig]
    int SetCurrentMediaType(
        int dwStreamIndex,
        IntPtr pdwReserved,
        IMFMediaType pMediaType
    );

2.
Imported the following methods (added to MFExtern)

    [DllImport("mfplat.dll", ExactSpelling = true), SuppressUnmanagedCodeSecurity]
    public static extern int MFCreateMFByteStreamOnStream(
        IStream pStream,
        out IMFByteStream ppByteStream
    );

    [DllImport("Mfreadwrite.dll", ExactSpelling = true), SuppressUnmanagedCodeSecurity]
    public static extern int MFCreateSourceReaderFromByteStream(
        IMFByteStream pByteStream,
        IMFAttributes pAttributes,
        out IMFSourceReader ppSourceReader
    );

What should I do in order to use it?

[snarfle]

1) You said you added SetCurrentMediaType to IMFSourceReader, but it is already there? Changing pdwReserved to IntPtr is a probably a good thing.

In order to move IMFSourceReader outside the #if ALLOW_UNTESTED_INTERFACES, I'd want to be sure all the methods are correct. Ideally by having some test code that calls each of them. Have you tried all the methods on this interface?

2) These methods are both already in MFExtern, but marked as untested. Moving them out of the #if just requires creating a bit of test code to be sure they are defined correctly.

[snarfle]

So, I have written the test code for these 3. There were a few changes (see IMFSourceReader in http://mfnet.cvs.sourceforge.net/viewvc/mfnet/mflib/src/MFReadWrite.cs?content-type=text%2Fplain). The test code (like all the test code for MFNet) is very basic (see http://mfnet.cvs.sourceforge.net/viewvc/mfnet/mflib/Test/v2.1/IMFSourceReaderTest.cs?content-type=text%2Fplain and http://mfnet.cvs.sourceforge.net/viewvc/mfnet/mflib/Test/v2.1/TestExterns.cs?content-type=text%2Fplain).

Try out the new IMFSourceReader and see what you think.

I suppose I could do a release with just the ~4 new interfaces. While I have added the (~23) W8.1 MF interfaces since the last release, they are all in the untested sections.

Seems a bit thin...

[Eric]

I think that you should rather wait for the release of Windows 10, now.

There will be changes in Media Foundation. So far, MKV and FLAC native support and HEVC decoder...

[snarfle]

<sigh> Putting yet more interfaces into the untested regions doesn't really seem productive. And I'm not actually using MFNet these days, so I'm not much motivated to write more test code. Or were you offering to help test these?

If Yakir has a serious need, he might be able to convince me to do a v2.1 with what's there right now.

[Eric]

I can work on validating the tests and possibly write new ones but if they requires Windows 8.1, I will have to install one in a VM...

[snarfle]

Actually, there are still a bunch of W7 interfaces that haven't been tested yet (see http://mfnet.cvs.sourceforge.net/viewvc/mfnet/mflib/Test/v2.1/v2-1-Interfaces.htm).

[Eric]

OK, I will work on that this week-end.