Originally created by: Akarsh-Hegde
After [#445] / [#446] merged into pre-main, CodeRabbit re-reviewed promotion PR [#440] and flagged 5 follow-ups on the fix code itself. All addressed here.
atomic_write_json — fsync before rename (Major): sync_all() the temp file before the atomic rename, so a crash/power-loss right after the rename can't persist the new directory entry while the data blocks are still buffered (empty/torn file). Hardens all three call sites (settings / analytics / account) at once.--purge short-circuit (Major, correctness): nothing_to_do() ignores ~/.meridian, so a --purge whose directory holds only uncatalogued files would print "Nothing to remove" and skip the wholesale rm -rf. Now the human path proceeds to the purge in that case.launchctl bootout's exit status stays best-effort in both paths (a not-loaded agent legitimately returns non-zero).save_account_email — span status (Minor): added err to #[tracing::instrument] so a failure marks the span ERROR.tempfile::TempDir so scratch dirs clean up via Drop, including during panic unwinding — no /tmp leak on a failing assertion.cargo test --lib: 437 pass; cargo test --lib uninstall + -p meridian-core fs_utils greencargo clippy -- -D warnings + cargo fmt --check: clean (root + tray)Last of the review follow-ups for [#440]. Once this lands on pre-main, [#440]'s diff reflects it.
🤖 Generated with Claude Code
Originally posted by: coderabbitai[bot]
✨ Finishing Touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/pr440-review-followups-2`Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Comment
@coderabbitai helpto get the list of available commands.Ticket changed by: Akarsh-Hegde