Originally created by: Akarsh-Hegde
Follow-up fixes for the CodeRabbit review threads on the pre-main → main promotion PR [#440]. Once this lands on pre-main, [#440]'s diff picks the fixes up automatically.
Per the triage on [#440], this branch carries the clear bugs, one privacy hardening, and the refactors approved for it. Two items are handled elsewhere: the Jira backfill critical is in its own focused PR [#446] (risky daemon-sync change), and the email→PostHog capture is a deliberate keep (copy softened instead).
rm -rf ~/.meridian on --purge only, not --remove-data && --remove-runtime (a user could set both without intending a full wipe). Fixed in the human and --json paths; regression test added.prune() unconditionally, so the empty-keys path deletes pm_task_embeddings before pm_tasks. The old fallback deleted pm_tasks directly and hit the FK, silently leaving stale tasks.reqwest timeout on the jira/azure create clients (matches azure_devops::apply).skip(email) in #[tracing::instrument] so the signed-in address never lands in a span field / log..context(...) on the fail_worklog / mark_post_failed DB calls.uninstall.rs + uninstall/json.rs + uninstall/tests.rs (each < 500 lines); the 13-arg run_json is now a Plan / Flags struct.fs_utils::atomic_write_json — one tested crash-safe temp+rename JSON writer; settings, tray analytics, and account all call it now..github/actions/import-apple-cert (shared by release.yml + release-staging.yml), with a graceful no-op when APPLE_CERTIFICATE is unset instead of crashing security import.catch blocks so a rejected Clerk promise surfaces to the user instead of an unhandled rejection.BrandIcon.viewBox/path together in the type so a glyph can't render a viewBox-less SVG.warn! → error! on genuine failure paths (uninstall commands, MLX runtime upgrade, backend install).commands.rs / api-types.ts "missing header comment" — already present on line 1 (CodeRabbit anchored mid-file); stale.CLAUDE.md "afterwards" → "afterward" — docs file, not user-facing app text; the US-locale nit doesn't apply.cargo test (workspace): 437 + integration suites passcargo clippy -- -D warnings: clean (root + tray)cargo fmt --check: clean (root + tray)cd tray/src-tauri && cargo test: 65 passcd ui && npm run build: clean (TypeScript check passes); bun test: 181 pass🤖 Generated with Claude Code
Originally posted by: coderabbitai[bot]
✨ Finishing Touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/pr440-review-followups`Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Comment
@coderabbitai helpto get the list of available commands.Ticket changed by: Akarsh-Hegde