#115 gtk3 branch fork on github

[Quantum immortal]

Letting you know, that there's a gtk3 branch fork on github, with lots of commits.
https://github.com/multiSnow/mcomix3

[multiSnow]

It is not a fork of gtk3. mcomix already has a gtk3 branch.
What I did is no more than porting it to python3, and python2 compatibility is totally droped.

[Ark]

I am sorry for the late reply. I just had a look at your repository, and it looks quite good. I especially like the fact that it looks like you managed to make the jump to Python 3 and GTK 3 on Linux. At least this is what the gtk3 branch looks like to me at first glance.

I would like to merge that branch into the repository here on SF. However, there are some things I noticed, and questions from my side. For the following discussion, "mcomix" may refer to the current Python 2 version on master (SF repository), and "mcomix3" may refer to the version on your gtk3 branch.

Some things I noticed while playing around with mcomix3:

• Using double page mode sometimes results in "Key Error"s being raised while navigating (only when using the mouse?).
• Navigation in mcomix3 using the mouse now depends on where you click. Interesting feature but not explained and/or not obvious. (I have a similar feature in mind where you can assign different actions to different parts of the panel. Not yet implemented, though.)
• The library handles archives much better.
• I could not make "Enable transform on animation" work. (In mcomix, there is no such option, and it does not work there, either.)
• Some images cannot be displayed anymore. (Sorry, I could not yet create appropriate test images for these cases.)
• Metadata-related issues (especially rotation stuff) do not lead to Exceptions anymore, and Exceptions do not render the whole application unusable. Very good!
• The command line parser in mcomix3 uses shlex. The syntax is different as well. Not sure how this works on different platforms (i.e. might affect Windows support).
• PDF files (maybe other containers as well?) are listed in the thumbnailer as if they were image files, but only a placeholder image is displayed.
• For some reason, the "Edit commands" menu item does not always open the corresponding window.
• Some features or options are absent in mcomix3 that are available for mcomix, e.g. "Page auto-resizing" (option) or automatically picking an appropriate color for the page numbers in the thumbnailer. (Maybe not merged?)
• Not sure about the current state of internationalization and/or localization. (Maybe some translations not merged?)
• Some minor issues like no double buffering (noticable when using the lens).
• The win32 directory is notably absent. Is there a specific reason why it has been removed? (Note: Referring to commit ca181c7651fd7cef3cb73ebd4aee0bcd2c4eeacc.)

Can you reproduce these issues or do you already know what causes them? Is there anything else noteworthy? Any questions from your side?

[multiSnow]

Let me answer your last issue at first:
mcomix3 does not support win32 since it is using pygi/gtk3 (see the Note of https://wiki.python.org/moin/PyGtk), so you may want keep mcomix running with py2 and pygtk.

for some others:

• I'm not sure but https://github.com/multiSnow/mcomix3/commit/9c641061904d4c07759a803794dec3c7b1209592 maybe fix the KeyError in double page mode.
• right to previous and left to next in manga mode, reversed in non-manga mode. maybe I should mention this feature in README.
• animation transform only working on APNG and animated webp. transform on animated gif is not supported since animated gif is still buggy in pillow (see https://github.com/python-pillow/Pillow/labels/GIF)
• external command interface is not tested on Windows, of course.
• I don't do any work on l10n, nor care about it. If someone make PRs about translation, they will be merged with no checking.