#74 No shutdown on SIGTERM after editing archive or opening empty archive

[Ark]

After opening the "Edit" → "Edit archive …" dialog, MComix does not respond to SIGTERM anymore. (You might be able to close the window but it needs a SIGKILL to get rid of the process.) Furthermore, if you close said dialog while thumbnails are being created, you will get this error:

Traceback (most recent call last):
  File "/home/ark/mcomix-code_svn/mcomix/thumbnail_view.py", line 109, in _pixbuf_finished
    iter = model.get_iter(path)
AttributeError: 'NoneType' object has no attribute 'get_iter'

Similarily, if you happen to open an empty archive, MComix won't respond to SIGTERM anymore as well. It seems that it does not matter how or when an empty archive has been opened.

This bug results in a resource leak since the user might not be aware of processes that are still running in the background due to this.

[Ark]

@Benoit Pierre: I guess that this has something to do with the concurrent archive extraction code. Could you please attend to this?

[Benoit Pierre]

Note: starting MComix with "-W all" is always a good idea to get more info on what's happening.

In this case, when trying to interrupt MComix, I get:

22:29:33 [MainThread] DEBUG: Waiting for thread <thread(thread-15-delete, started="" 47756836349696)=""> to finish before exit
22:29:33 [MainThread] DEBUG: Waiting for thread <thread(thread-13-thumbview, started="" 47756862281472)=""> to finish before exit</thread(thread-13-thumbview,></thread(thread-15-delete,>

So it looks like the thumbview was not properly stopped. I'll look into it.

[Benoit Pierre]

I pushed a fix.

[Ark]

Thanks, this seems to fix this issue for the "Edit archive" part. However, the "empty archive" part is still present. Could you please fix this, too?

Thanks for the note, I just added an alias for my shell to make sure that I use the -W option.

[Ark]

A test just revealed that the archive does not need to be completely empty. A simple archive with only a single txt file in it is sufficient to trigger this. That is, MComix does not shut down properly if you open an archive that does not contain any image files (i.e. the thumbnailer remains empty). However, an empty png file is enough to make MComix display a "broken image" icon and let it shutdown without any problems.

[Benoit Pierre]

Yep, I pushed a fix for that.

[Ark]

Great work, thank you.