#142 '<Shift>space' shortcut does not work

[Dan W]

I'm running MComix on Windows 10.

It is not possible to assign <Shift>space in the GUI. Setting it via the keybindings.conf file, it does not work properly.

While this works:

  "previous_page": [
    "u"
  ],
  "next_page": [
    "j"
  ],

This does not:

  "previous_page": [
    "<Shift>space"
  ],
  "next_page": [
    "space"
  ],

Instead, both <Shift>space and space advance to the next page.

[Oddegamra]

Might also affect other special keys, e.g. PgUp/Down together with SHIFT. From what I can see, in events.py, key_press_event() has some code that might have been intended to guard against this problem, but doesn't trigger for Space. To begin with, GTK3 gives a bitmask of "comsumed" modifiers that were used to create the actually pressed key, which is then removed from the actual key passed down into the keyboard handler.

On Windows, this "consumed" value contains the SHIFT key, while it contains nothing on Linux. Thus, the keyboard handler never gets to see that SHIFT was pressed, and does not trigger the correct action.

[Oddegamra]

I'm carefully optimistic that this bug should be fixed now.