Re: [matplotlib-devel] Patch for enhancement of PDF backend

[<jk...@ik...>]

"Nicolas Grilly" <nic...@ga...> writes:

> Here is a patch I promised some time ago, to improve the PDF backend.

Thanks; on first look this seems really nice! So far I have one
request to you and one to John:

Nicolas: would it be easy for you to strip the ^M (carriage-return)
characters from your files and then re-run diff? I see in your patch
several parts where the only change seems to be an addition of ^M at
the end of each line, but there could be significant changes hidden
within these parts. (Perhaps just give the -b option to diff? Though
that might backfire if some other whitespace changes are significant,
e.g. if you have changed the indentation of some code blocks.)

John: Is Adobe's licensing of the AFM files compatible with
matplotlib's license? I think it is, but I'm no license expert. The
readme file distributed with the files contains the following text:

  Font Metrics for the 14 PDF Core Fonts
  ======================================

  This directory contains font metrics for the 14 PDF Core Fonts (files with .afm 
  extension), downloaded from http://partners.adobe.com/public/developer/font/index.html.

  This file and the 14 PostScript(R) AFM files it accompanies may be used, copied, 
  and distributed for any purpose and without charge, with or without modification, 
  provided that all copyright notices are retained; that the AFM files are not 
  distributed without this file; that all modifications to this file or any of 
  the AFM files are prominently noted in the modified file(s); and that this 
  paragraph is not modified. Adobe Systems has no responsibility or obligation 
  to support the use of the AFM files.


-- 
Jouni K. Seppänen
http://www.iki.fi/jks