From: John H. <jdh...@ac...> - 2007-01-12 14:44:58
|
>>>>> "Steve" == Steve Chaplin <ste...@ya...> writes: Steve> I propose this new version of buffer_bgra32 (and Steve> buffer_argb32). I tested it with cairo and it seems to work Steve> OK. This looks good -- please test it with one of the memleak scripts, eg a variant of units/memleak_hawaii.py to make sure everything is being cleaned up properly. If you feel motivated, please port these over to the other buffer methods. One way to do this cleanly would be to set up an enum of the agg pixel formats supported by agg::color_conv and then simply allow the user to pass in the pixel format desired. Ie, support color_conv_rgba32_to_abgr32 color_conv_rgba32_to_argb32 color_conv_rgba32_to_bgra32 in a single function with a single arg. JDH |