|
From: Benjamin R. <ben...@ou...> - 2012-12-19 15:57:21
|
On Tue, Dec 18, 2012 at 2:05 PM, Darren Dale <dsd...@gm...> wrote: > On Mon, Dec 10, 2012 at 3:45 AM, Phil Elson <pel...@gm...> wrote: > > Thanks for bringing this up, it is certainly valuable to highlight this > on > > the mailinglist. As you say, the change is hard to spot and, I agree, > makes > > library code supporting v1.1.1 and v1.2 harder than one would like. > > Typically, anything which is going to break core APIs (even slightly) > should > > be documented under the "API Changes" page here > > http://matplotlib.org/api/api_changes.html#changes-in-1-2-x > > I suggest that an API change should have triggered a major version > bump to mpl-2.0.0. It seems a well-established expectation for a > major.minor.bugfix versioning scheme that bugfix releases will not > introduce new features, and minor releases will not introduce API > changes. > > Darren > > Agreed. I think what happened here was short-sightedness (somewhat on my part since I was involved in that PR). I didn't realize this sort of situation when I reviewed it. This originally looked more like an enhancement that a more fundamental change. My apologies. Ben Root |