Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

[Christoph G. <cg...@uc...>]

On 3/9/2011 12:01 PM, Benjamin Root wrote:
>
>
> On Wed, Mar 9, 2011 at 5:23 AM, Christoph Gohlke <cg...@uc...
> <mailto:cg...@uc...>> wrote:
>
>     Hello,
>
>     please consider the attached patch for the matplotlib-py3 CTPUG fork
>     on github. The patch fixes several build and runtime issues/crashes.
>     Tested on win-amd64-py3.2.
>
>     Christoph
>
>
> Christoph,
>
> A quick point of style looking over this patch.  Rather than renaming
> "collections" to "mplcollections", we really should follow our own
> conventions and call it "mcoll".  The same is probably true for text and
> other matplotlib objects.
>
> http://matplotlib.sourceforge.net/devel/coding_guide.html#style-guide
>
> Then again, maybe some of these style changes should be made to master
> first and then merged into the py3k branch?  The coding style is
> something we have been falling behind on and really should clean up at
> some point.
>
> As for the rest of it, I don't have enough experience with py3k to comment.
>
> Ben Root
>

OK. The revised patch changes the name to mcoll and fixes further 
issues. I also reworked the examples to be compatible with Python 2.6+ 
and 3.x without the need to run the 2to3 tool. On Windows all but three 
examples now work on Python 3.2.

Christoph