Re: [matplotlib-devel] axes.frame not drawn while axes.draw() called

[Paul K. <pki...@ni...>]

On Mon, Jul 28, 2008 at 10:40:47AM -0500, John Hunter wrote:
> On Mon, Jul 28, 2008 at 10:30 AM, Jae-Joon Lee <lee...@gm...> wrote:
> > Hi John,
> >
> > I'm a bit confused. When you say 1st instance, you mean
> >
> >        if self.axison and self._frameon:
> >            self.patch.draw(renderer)
> >
> > at line 1452?
> 
> Sorry, I was confused.  I misread the first patch drawing as a frame
> drawing.  I am adding the frame back in.  Paul removed it in the
> commit
> 
>   r5882 | pkienzle | 2008-07-25 19:01:18 -0500 (Fri, 25 Jul 2008) | 1 line
> 
>   Fix contains() for lines; don't redraw axis frame
> 
> Paul, were you also mistaking the patch for the frame?  I looked at
> the Axes code and noticed the patch was drawing the edge, which is the
> job of the frame.  I am turning the patch edgecolor off by default,
> which is what I think it should be doing, but Eric, can you confirm?

Sorry!  I didn't look carefully enough at the problem.

The issue is that my onHilite demo code sees the top frame, fills it,
and blanks out the rest of the window, making it impossible for me
to check that it is doing the right thing.  I was naively assuming
the rectangle that draws the frame also draws the background.

Please put a comment in the code saying why it is duplicated so
that I don't stupidly remove it again the next time I work with
onHilite.

	- Paul