Re: [matplotlib-devel] reverting changes to contour.py

[Eric F. <ef...@ha...>]

David M. Kaplan wrote:
> Hi,
> 
> Sorry about the problems.  The labeling code is somewhat difficult to
> understand and I was using label indices when I should have used level
> indices (or vice-versa).  I have a fix, but want to test it more before
> committing.  Let me know when is a good time to do it so that I don't
> mess up a release.

It sounds like there is time to do it before the release without messing 
up the release.  Just make sure the backend_drivers.py test suite still 
runs OK.  If you can add tests (i.e., examples run by backend_drivers) 
that exercise the new functionality, that is even better.  The 
interactive part of the functionality can't be tested in an automated 
way, but the rest can, and adding an example is a good way to help users 
see how to use it.  In any case, go ahead and commit when ready.

Yes, the labeling code is difficult, and I have not looked at it in a 
long time.  If you are interested, please do look at it from the 
standpoint of a possible major revision that might make it easier to 
understand and easier to enhance.

Eric

> 
> Cheers,
> David
> 
> On Sat, 2008-07-19 at 19:30 -0700,
> mat...@li... wrote:
>> David,
>>
>> I am reverting your changes to contour.py; that is, I am taking it
>> back 
>> to 5689.  The problem is that running contour_demo.py, below, fails. 
>> Some index accounting somewhere is getting fouled up.  I don't have
>> time 
>> to investigate.
>>
>> When you have it straightened out you can put the changes back, so
>> this 
>> is just a brief setback.
>>
>> We might want to consider, however, whether such extensive changes 
>> should be made immediately *before* a "bugfix" release.  I think John
>> is 
>> trying to get one out.  I am already a little nervous about other
>> recent 
>> and impending changes in this context.  (Your idea of a branch was a 
>> good one in concept, but maybe a pain and more trouble than it is
>> worth 
>> with svn.  Too bad we aren't using something nice like Mercurial.
>> Now, 
>> that comment should push a few buttons.)
>>
>> Eric
>>