Menu

#77 TCPIPReadLineTCP return value

3.0b11
pending-fixed
None
5
2019-07-16
2018-11-12
No

https://sourceforge.net/p/marinetti/code/HEAD/tree/trunk/MOSP/Marinetti/Init/I.INIT.S#l2166

~~~
STA 2+1+RAWSTACKEDPARMS+16,S
~~~

That should be
~~~
STA 2+1+RAWSTACKEDPARMS+20,S
~~~
I believe. It seems to have been copied verbatim from TCPIPReadTCP but the extra LongWord parameter wasn't accounted for.

Discussion

  • Andrew Roughan

    Andrew Roughan - 2018-11-16

    Internal note: PC;GSport;NewDev2;Testbuild;Init;I.Init.B77.S & Testbuild:Changelog.b10

     

    Last edit: Andrew Roughan 2018-11-16
  • Andrew Roughan

    Andrew Roughan - 2019-07-16

    Stephen Huemann reported that the LOOKFORDELIMIT routine was not setting the TCP ErrorCode correctly in the user record, so a value set by earlier code may remain present there. This may lead to it returning an error code like tcperrConClosing even when successfully returning data. He suggested the following change (where lines beginning with '+' are additions.

    BNEL :SCANLOOP

    • BRA :NOLINE

    • Exit Code

    :EXITOK

    • LDA #tcperrOK
    • LDY #uwTCP_ErrCode
    • STA [USERPTR],Y
      :NOLINE JSR :SETMOREFLAG
      LDA #terrOK ;is $0000 so no ORA >MYTOOLSETNUMBER needed
      PLB
      RTL
     
  • Andrew Roughan

    Andrew Roughan - 2019-07-16
    • Group: 3.0b10 --> 3.0b11
     
  • Andrew Roughan

    Andrew Roughan - 2019-07-16

    Internal note: PC;GSport;NewDev2;Testbuild;Init;I.TCP.B77.S & Testbuild:Changelog.b11

     

Log in to post a comment.